You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/08/12 00:42:59 UTC

[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3075: GOBBLIN-1229: Make topic specific state available to Kafka workunit packer

sv2000 opened a new pull request #3075:
URL: https://github.com/apache/incubator-gobblin/pull/3075

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1229

### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
We enhance the kafka bin packer by adding topic specific configuration into the workunits passed to the workunit packer. In addition, we also add information about the number of topic partitions for the respective kafka topic into the workunit.

### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Existing unit tests.

### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] sv2000 closed pull request #3075: GOBBLIN-1229: Make topic specific state available to Kafka workunit packer

Posted by GitBox <gi...@apache.org>.

sv2000 closed pull request #3075:
URL: https://github.com/apache/incubator-gobblin/pull/3075


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] sv2000 commented on pull request #3075: GOBBLIN-1229: Make topic specific state available to Kafka workunit packer

Posted by GitBox <gi...@apache.org>.

sv2000 commented on pull request #3075:
URL: https://github.com/apache/incubator-gobblin/pull/3075#issuecomment-672405655


   @autumnust @ZihanLi58 Please review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] asfgit closed pull request #3075: GOBBLIN-1229: Make topic specific state available to Kafka workunit packer

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #3075:
URL: https://github.com/apache/incubator-gobblin/pull/3075


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org