You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/10/06 21:03:52 UTC
[GitHub] [druid] vtlim opened a new pull request, #13191: Docs: update description of query priority default value
vtlim opened a new pull request, #13191:
URL: https://github.com/apache/druid/pull/13191
Clarifies the order in which configurations are read to determine the default query priority. Also updates some styling for the config names within the tables.
This PR has:
- [x] been self-reviewed.
Updated in https://druid.apache.org/docs/latest/querying/query-context.html
<img width="613" alt="image" src="https://user-images.githubusercontent.com/7747997/194418029-d6bb4704-9197-4d76-a539-9ce97d1f37ba.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #13191: Docs: update description of query priority default value
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on PR #13191:
URL: https://github.com/apache/druid/pull/13191#issuecomment-1276797602
Looks great. Thanks also for adding all the back-ticks.
One small improvement. I like the list items. When reading the first, my immediate question is "which config key"?
The other nit is we need to decide on what we call the thingies in the query context. I've seem "parameter" (but, easily confused with a query parameter), "entry", "value" and now "configuration". Might I suggest "entry" for the whole thing and "key" for the name? Those don't conflict with other common terms in Druid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith merged pull request #13191: Docs: update description of query priority default value
Posted by GitBox <gi...@apache.org>.
techdocsmith merged PR #13191:
URL: https://github.com/apache/druid/pull/13191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a diff in pull request #13191: Docs: update description of query priority default value
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on code in PR #13191:
URL: https://github.com/apache/druid/pull/13191#discussion_r993986230
##########
docs/querying/query-context.md:
##########
@@ -37,34 +37,34 @@ Note that setting query context will override both the default value and the run
Unless otherwise noted, the following parameters apply to all query types.
Review Comment:
```suggestion
Unless otherwise noted, the following properties apply to all query types.
```
If they're properties in the table, should they be properties in the intro?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13191: Docs: update description of query priority default value
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #13191:
URL: https://github.com/apache/druid/pull/13191#discussion_r994956171
##########
docs/querying/query-context.md:
##########
@@ -37,34 +37,34 @@ Note that setting query context will override both the default value and the run
Unless otherwise noted, the following parameters apply to all query types.
Review Comment:
Apparently "parameters" is all over this doc but I think "properties" would be the more accurate term. Updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13191: Docs: update description of query priority default value
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #13191:
URL: https://github.com/apache/druid/pull/13191#discussion_r994956171
##########
docs/querying/query-context.md:
##########
@@ -37,34 +37,34 @@ Note that setting query context will override both the default value and the run
Unless otherwise noted, the following parameters apply to all query types.
Review Comment:
Apparently "parameters" is all over this doc but I think "properties" would be the more accurate term. Will check and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org