You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by svenmeier <gi...@git.apache.org> on 2017/12/14 08:39:45 UTC
[GitHub] wicket pull request #250: WICKET-6503 render cleanup and ajax
GitHub user svenmeier opened a pull request:
https://github.com/apache/wicket/pull/250
WICKET-6503 render cleanup and ajax
This is a combined effort to:
- align Ajax requests with the way components are prepared in normal request, i.e. beforeRender is called on *all* components, before any of them is rendered
- unify rendering of components separately as part of a page only vs. a whole page
- improve performance by prevent unnecessary traversal of the component hierarchy
- cleanup component's internal methods and flags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6503_ajax_feedback_prepare
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
----
---
[GitHub] wicket issue #250: WICKET-6503 render cleanup and ajax
Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/250
All test pass, there is a single change in FeedbackRenderTest only:
If IFeedbacks are *nested* (e.g. id1 -> id2 -> id3), *they* are prepared for render top-down (i.e. id1 then id2 then id3). This matches they way other components are rendered.
Previously the order was the other way around (i.e. id3 then id2 then id1), which was wrong IMHO.
---
[GitHub] wicket pull request #250: WICKET-6503 render cleanup and ajax
Posted by svenmeier <gi...@git.apache.org>.
GitHub user svenmeier reopened a pull request:
https://github.com/apache/wicket/pull/250
WICKET-6503 render cleanup and ajax
This is a combined effort to:
- align Ajax requests with the way components are prepared in normal request, i.e. beforeRender is called on *all* components, before any of them is rendered
- unify rendering of components separately as part of a page only vs. a whole page
- simplify handling of feedbacks ... this was a real mess :(
- improve performance by prevent unnecessary traversal of the component hierarchy
- cleanup component's internal methods and flags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6503_ajax_feedback_prepare
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit e2b6205fff61a8d8c0dc28d7749ec467278f7c80
Author: Sven Meier <sv...@apache.org>
Date: 2017-12-14T06:55:53Z
WICKET-6503 beforeRender clean-up
----
---
[GitHub] wicket issue #250: WICKET-6503 render cleanup and ajax
Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/250
This does *not* solve (yet) one aspect of WICKET-6503: should components be allowed to be added to an AjaxRequestTarget *after* components have already been rendered ("ART is already frozen").
---
[GitHub] wicket pull request #250: WICKET-6503 render cleanup and ajax
Posted by svenmeier <gi...@git.apache.org>.
Github user svenmeier closed the pull request at:
https://github.com/apache/wicket/pull/250
---
[GitHub] wicket pull request #250: WICKET-6503 render cleanup and ajax
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/250
---