You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/19 05:01:56 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1517: [CALCITE-3426] Compensate validConstant type in RexLiteral

jinxing64 commented on a change in pull request #1517: [CALCITE-3426] Compensate validConstant type in RexLiteral
URL: https://github.com/apache/calcite/pull/1517#discussion_r336722573
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexLiteral.java
 ##########
 @@ -456,9 +456,13 @@ private static RexDigestIncludeType shouldIncludeType(Comparable value, RelDataT
    * criteria as {@link #valueMatchesType}. */
   public static boolean validConstant(Object o, Litmus litmus) {
     if (o == null
 
 Review comment:
   I think so ~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services