You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/18 08:52:44 UTC
[GitHub] [flink] xmarker opened a new pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
xmarker opened a new pull request #17319:
URL: https://github.com/apache/flink/pull/17319
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Fix PulsarSourceITCase fails due to port conflict*
## Brief change log
- *PulsarMockRuntime use runtime dynamic port*
## Verifying this change
*(Please pick either of the following options)*
This change is to fix unit test failed issue .
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25ccc21ec1a721f0c197c8b3f764933446ed7b89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297)
* 1807cfc8902d6b3192f4b422e115e9cacc24fb60 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] syhily commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
syhily commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-923025732
> There's an unused import, and if this change works then the PordBindingUtils can be removed.
I have checked the internal logic on the Pulsar side. Change the port to zero should work for both Pulsar broker and Pulsar WebService. Tks for your fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922243751
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 25ccc21ec1a721f0c197c8b3f764933446ed7b89 (Sat Sep 18 08:55:00 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24329).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xmarker commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
xmarker commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-923823553
> > > @xmarker `PortBindingUtils` should also be removed.
> >
> >
> > Hi syhily , thinks for review，I checked again and PortBindingUtils import has been removed by the second commit
>
> I mean, remove the `PortBindingUtils` class.
OK, I pushed again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25ccc21ec1a721f0c197c8b3f764933446ed7b89 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
}, {
"hash" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"triggerType" : "PUSH"
}, {
"hash" : "0414dbd560746bc38d7933485aae047885beea34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24352",
"triggerID" : "0414dbd560746bc38d7933485aae047885beea34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9 UNKNOWN
* 0414dbd560746bc38d7933485aae047885beea34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24352)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25ccc21ec1a721f0c197c8b3f764933446ed7b89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
}, {
"hash" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"triggerType" : "PUSH"
}, {
"hash" : "0414dbd560746bc38d7933485aae047885beea34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0414dbd560746bc38d7933485aae047885beea34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1807cfc8902d6b3192f4b422e115e9cacc24fb60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333)
* 79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9 UNKNOWN
* 0414dbd560746bc38d7933485aae047885beea34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25ccc21ec1a721f0c197c8b3f764933446ed7b89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297)
* 1807cfc8902d6b3192f4b422e115e9cacc24fb60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] syhily commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
syhily commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-923702381
> > @xmarker `PortBindingUtils` should also be removed.
>
> Hi syhily , thinks for review，I checked again and PortBindingUtils import has been removed by the second commit
I mean, remove the `PortBindingUtils` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xmarker commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
xmarker commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-923489512
> @xmarker `PortBindingUtils` should also be removed.
Hi syhily , thinks for review，I checked again and PortBindingUtils import has been removed by the second commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1807cfc8902d6b3192f4b422e115e9cacc24fb60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17319:
URL: https://github.com/apache/flink/pull/17319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25ccc21ec1a721f0c197c8b3f764933446ed7b89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] syhily commented on a change in pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
syhily commented on a change in pull request #17319:
URL: https://github.com/apache/flink/pull/17319#discussion_r712268012
##########
File path: flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/mock/PulsarMockRuntime.java
##########
@@ -146,8 +146,8 @@ private static ServiceConfiguration createConfig() {
configuration.setWebSocketServiceEnabled(false);
// Binding Ports
- configuration.setBrokerServicePort(Optional.of(findAvailablePort()));
- configuration.setWebServicePort(Optional.of(findAvailablePort()));
+ configuration.setBrokerServicePort(Optional.of(0));
+ configuration.setWebServicePort(Optional.of(0));
Review comment:
PortBindingUtils is useless, just remove it. And remove the unused import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] syhily commented on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
syhily commented on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-923124598
@xmarker `PortBindingUtils` should also be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
}, {
"hash" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"triggerType" : "PUSH"
}, {
"hash" : "0414dbd560746bc38d7933485aae047885beea34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24352",
"triggerID" : "0414dbd560746bc38d7933485aae047885beea34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1807cfc8902d6b3192f4b422e115e9cacc24fb60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333)
* 79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9 UNKNOWN
* 0414dbd560746bc38d7933485aae047885beea34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24352)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17319: [FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17319:
URL: https://github.com/apache/flink/pull/17319#issuecomment-922249634
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24297",
"triggerID" : "25ccc21ec1a721f0c197c8b3f764933446ed7b89",
"triggerType" : "PUSH"
}, {
"hash" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333",
"triggerID" : "1807cfc8902d6b3192f4b422e115e9cacc24fb60",
"triggerType" : "PUSH"
}, {
"hash" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1807cfc8902d6b3192f4b422e115e9cacc24fb60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24333)
* 79d47d6765dfc205b1ff9e5d59e0e3b17c668bd9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org