[GitHub] [helix] jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337792566
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -412,6 +429,30 @@ private void refreshBaseline(ResourceControllerDataProvider clusterData,
     return newAssignment;
   }
 
+  private void measureBaselineDivergenceGauge(Map<String, ResourceAssignment> baseline,
+      Map<String, ResourceAssignment> bestPossibleAssignment) {
+    MapDifference<String, ResourceAssignment> mapDifference =
+        Maps.difference(baseline, bestPossibleAssignment);
+    Map<String, ResourceAssignment> matchedAssignment = mapDifference.entriesInCommon();
+    Map<String, MapDifference.ValueDifference<ResourceAssignment>> differentAssignment =
+        mapDifference.entriesDiffering();
 
 Review comment:
   This diff only shows if anything diff in the ResourceAssignment, right?
   I think we need to check at the single partition level, at least.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org