[GitHub] [storm] agresch opened a new pull request #3169: STORM-3540 fix Pacemaker connection issues

[GitBox <gi...@apache.org>]

agresch opened a new pull request #3169: STORM-3540 fix Pacemaker connection issues
URL: https://github.com/apache/storm/pull/3169
 
 
   "Exception occurred in Pacemaker" message was not logging cause properly until I changed the message for some reason.
   
   Problem:
   
   1) ThriftNettyClientCodec.initChannel() is called, which we map to PacemakerClient.channelReady().
   2) We get a pacemaker message to write
   3) We see the channel as ready and write/flush the message
   4) The flush causes a NotYetConnected exception
   5) This triggers a reconnect
   6) The reconnect causes us to go to step 1) and we get stuck in a loop failing to talk to Pacemaker
   
   The solution I think is more appropriate:
   
   PacemakerClientHandler.channelActive() should be the one calling PacemakerClient.channelReady().
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services