You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by sa...@apache.org on 2016/10/06 20:07:06 UTC
incubator-airflow git commit: [AIRFLOW-556] Add UI PR guidelines
Repository: incubator-airflow
Updated Branches:
refs/heads/master 4405940c3 -> 99e7d8c61
[AIRFLOW-556] Add UI PR guidelines
For all PRs with UI changes, it is a requirement
that screenshots be included in the PR. Update
PULL_REQUEST_TEMPLATE with this PR guideline for
UI changes.
Closes #1829 from r39132/master
Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/99e7d8c6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/99e7d8c6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/99e7d8c6
Branch: refs/heads/master
Commit: 99e7d8c61b25aeaf8a507cff0af10dc158159a4d
Parents: 4405940
Author: Siddharth Anand <si...@yahoo.com>
Authored: Thu Oct 6 13:07:18 2016 -0700
Committer: Siddharth Anand <si...@yahoo.com>
Committed: Thu Oct 6 13:07:18 2016 -0700
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE.md | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/99e7d8c6/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 3e497bd..5681a89 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -15,6 +15,9 @@ Reminders for contributors (REQUIRED!):
[Airflow's JIRA](https://issues.apache.org/jira/browse/AIRFLOW/).
For example, a PR called "[AIRFLOW-1] My Amazing PR" would close JIRA
issue #1. Please open a new issue if required!
+
+* For all PRs with UI changes, you must provide screenshots. If the UI changes are not obvious, either annotate the images or provide before/after screenshots.
+
* Please squash your commits when possible and follow the [How to write a good git commit message](http://chris.beams.io/posts/git-commit/).
Summarized as follows:
1. Separate subject from body with a blank line
@@ -22,4 +25,5 @@ Summarized as follows:
3. Do not end the subject line with a period
4. Use the imperative mood in the subject line (add, not adding)
5. Wrap the body at 72 characters
- 6. Use the body to explain what and why vs. how
\ No newline at end of file
+ 6. Use the body to explain what and why vs. how
+