You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by zezutom <gi...@git.apache.org> on 2017/05/09 05:23:28 UTC

[GitHub] incubator-metron pull request #572: METRON-633: Create better logging for Hb...

GitHub user zezutom opened a pull request:

    https://github.com/apache/incubator-metron/pull/572

    METRON-633: Create better logging for HbaseEnrichmentWriter

    ## Contributor Comments
    I have added logging to critical paths, so that issues can be tracked down more easily.
    
    ## Pull Request Checklist
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zezutom/incubator-metron METRON-633

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #572
    
----
commit d31ff93b24922341b6443a2e881973406d15bccc
Author: zezutom <ze...@gmail.com>
Date:   2017-05-08T21:40:47Z

    Added debug / warn logs to critical paths, unit tests checking format of the captured logs.

commit 3dc993e602721844e2c24d1631e61d4d56224375
Author: zezutom <ze...@gmail.com>
Date:   2017-05-08T22:50:16Z

    Adding license info.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---