[GitHub] [calcite] rubenada commented on a change in pull request #1365: [CALCITE-3198] Enhance RexSimplify to handle '(x<>a or x<>b)' (fix javadoc)

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1365: [CALCITE-3198] Enhance RexSimplify to handle '(x<>a or x<>b)' (fix javadoc)
URL: https://github.com/apache/calcite/pull/1365#discussion_r312406455
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
 ##########
 @@ -2188,7 +2188,7 @@ public void testMinusMergeRule() throws Exception {
 
   /** Test case for
    * <a href="https://issues.apache.org/jira/browse/CALCITE-3198">[CALCITE-3198]
-   * Enhance RexSimplify to handle (x<>a or x<>b)</a>. */
+   * Enhance RexSimplify to handle (x!=a or x!=b)</a>. */
   @Test public void testReduceConstantsDup3Null() throws Exception {
 
 Review comment:
   It was just a quick fix, since the usage of "<>" broke the javadoc:
   ```
   [ERROR]    .../apache/calcite/test/RexProgramTest.java:1532: error: bad use of '>'
   [ERROR]    * Enhance RexSimplify to handle (x<>a or x<>b)</a>. */
   [ERROR]                                               ^
   ```
   It is just the javadoc of a unit test, I think using "<>" or "!=" was not very relevant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services