You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/24 08:24:02 UTC
[PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
laglangyue opened a new pull request, #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66
## This PR inclueds:
migrate `shopping-cart-service-cassandra-java` to pekko
## Test
Failed, there are some problems of configratution.
This module can be compiled with `mvn clean package -DskipTests=true`,
Due to lack of pekko-persistences of me and changes of configuration,I can't finish the test now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435790912
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/pom.xml:
##########
@@ -15,99 +15,106 @@
</license>
</licenses>
- <!-- tag::akka-persistence-cassandra[] -->
+ <!-- tag::pekko-persistence-cassandra[] -->
<properties>
- <!-- end::akka-persistence-cassandra[] -->
+ <!-- end::pekko-persistence-cassandra[] -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <akka-grpc-maven-plugin.version>2.1.3</akka-grpc-maven-plugin.version>
+ <pekko-grpc-maven-plugin.version>1.0.1</pekko-grpc-maven-plugin.version>
+ <pekko.version>1.0.2</pekko.version>
+ <pekko.connectors.version>1.0.1</pekko.connectors.version>
+ <pekko.projection.version>1.0.0</pekko.projection.version>
+ <pekko.grpc.version>1.0.0</pekko.grpc.version>
+ <pekko.persistence.jdbc.version>1.0.0</pekko.persistence.jdbc.version>
+ <pekko.persistence.cassandra.version>1.0.0</pekko.persistence.cassandra.version>
+ <pekko.connectors.kafka.version>1.0.0</pekko.connectors.kafka.version>
+ <pekko.management.version>1.0.0</pekko.management.version>
<scala.binary.version>2.13</scala.binary.version>
<!-- needs to be defined to allow for overriding through mvn exec:exec -DAPP_CONFIG=local1.conf -->
<APP_CONFIG>application.conf</APP_CONFIG>
<!-- Version of the Docker image is derived from git commit.
It can be defined with -Dversion.number=0.1-SNAPSHOT if git is not used -->
<version.number>${git.commit.time}-${git.commit.id.abbrev}</version.number>
- <!-- tag::akka-persistence-cassandra[] -->
+ <!-- tag::pekko-persistence-cassandra[] -->
</properties>
- <!-- end::akka-persistence-cassandra[] -->
+ <!-- end::pekko-persistence-cassandra[] -->
- <dependencyManagement>
Review Comment:
I didn't find it similar at first. Get it now, thanks.
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-bom_${scala.binary.version}</artifactId>
<version>${pekko.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435787650
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/pom.xml:
##########
@@ -75,8 +76,15 @@
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-discovery_${scala.binary.version}</artifactId>
- <version>${pekko.version}</version>
+ <version>${pekko.discovery.version}</version>
</dependency>
+ <!-- https://mvnrepository.com/artifact/org.apache.pekko/pekko-discovery-kubernetes-api -->
Review Comment:
remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#issuecomment-1868518192
I've merged in latest main code and fixed some issues.
There are 2 tests failing. I haven't had time to debug why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435791399
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/pom.xml:
##########
@@ -187,9 +206,9 @@
</plugin>
<plugin>
- <groupId>com.lightbend.akka.grpc</groupId>
- <artifactId>akka-grpc-maven-plugin</artifactId>
- <version>${akka-grpc-maven-plugin.version}</version>
+ <groupId>org.apache.pekko</groupId>
+ <artifactId>pekko-grpc-maven-plugin</artifactId>
+ <version>${pekko-grpc-maven-plugin.version}</version>
Review Comment:
use pekko-grpc.version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435784638
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/pom.xml:
##########
@@ -15,99 +15,106 @@
</license>
</licenses>
- <!-- tag::akka-persistence-cassandra[] -->
+ <!-- tag::pekko-persistence-cassandra[] -->
<properties>
- <!-- end::akka-persistence-cassandra[] -->
+ <!-- end::pekko-persistence-cassandra[] -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <akka-grpc-maven-plugin.version>2.1.3</akka-grpc-maven-plugin.version>
+ <pekko-grpc-maven-plugin.version>1.0.1</pekko-grpc-maven-plugin.version>
+ <pekko.version>1.0.2</pekko.version>
+ <pekko.connectors.version>1.0.1</pekko.connectors.version>
+ <pekko.projection.version>1.0.0</pekko.projection.version>
+ <pekko.grpc.version>1.0.0</pekko.grpc.version>
+ <pekko.persistence.jdbc.version>1.0.0</pekko.persistence.jdbc.version>
+ <pekko.persistence.cassandra.version>1.0.0</pekko.persistence.cassandra.version>
+ <pekko.connectors.kafka.version>1.0.0</pekko.connectors.kafka.version>
+ <pekko.management.version>1.0.0</pekko.management.version>
<scala.binary.version>2.13</scala.binary.version>
<!-- needs to be defined to allow for overriding through mvn exec:exec -DAPP_CONFIG=local1.conf -->
<APP_CONFIG>application.conf</APP_CONFIG>
<!-- Version of the Docker image is derived from git commit.
It can be defined with -Dversion.number=0.1-SNAPSHOT if git is not used -->
<version.number>${git.commit.time}-${git.commit.id.abbrev}</version.number>
- <!-- tag::akka-persistence-cassandra[] -->
+ <!-- tag::pekko-persistence-cassandra[] -->
</properties>
- <!-- end::akka-persistence-cassandra[] -->
+ <!-- end::pekko-persistence-cassandra[] -->
- <dependencyManagement>
Review Comment:
could you use the pekko-bom like I used in microservices tutorials for consistency? If you use that, then you don't need to set the pekko version on the jars that were `<groupId>com.typesafe.akka</groupId>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#issuecomment-1868723929
> I've merged in latest main code and fixed some issues.
>
> There are 2 tests failing. I haven't had time to debug why.
>
> @laglangyue if you want to, you can try fixing this. I will try again in next few days. Please don't create any more code change PRs for this repo. It is easier to upgrade them altogether instead of 1 at a time. I did all the microservices-tutorials changes yesterday in 1 PR.
get it, I would like to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#issuecomment-1868461746
I need more time to style the pekko-persistence and then finish the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435787595
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/pom.xml:
##########
@@ -75,8 +76,15 @@
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-discovery_${scala.binary.version}</artifactId>
- <version>${pekko.version}</version>
+ <version>${pekko.discovery.version}</version>
Review Comment:
this is wrong - pekko-discovery is part of the core pekko and should use v1.0.2
pekko-discovery-kubernetes-api is part of pekko-management and should use pekko-management.version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435790912
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/pom.xml:
##########
@@ -15,99 +15,106 @@
</license>
</licenses>
- <!-- tag::akka-persistence-cassandra[] -->
+ <!-- tag::pekko-persistence-cassandra[] -->
<properties>
- <!-- end::akka-persistence-cassandra[] -->
+ <!-- end::pekko-persistence-cassandra[] -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <akka-grpc-maven-plugin.version>2.1.3</akka-grpc-maven-plugin.version>
+ <pekko-grpc-maven-plugin.version>1.0.1</pekko-grpc-maven-plugin.version>
+ <pekko.version>1.0.2</pekko.version>
+ <pekko.connectors.version>1.0.1</pekko.connectors.version>
+ <pekko.projection.version>1.0.0</pekko.projection.version>
+ <pekko.grpc.version>1.0.0</pekko.grpc.version>
+ <pekko.persistence.jdbc.version>1.0.0</pekko.persistence.jdbc.version>
+ <pekko.persistence.cassandra.version>1.0.0</pekko.persistence.cassandra.version>
+ <pekko.connectors.kafka.version>1.0.0</pekko.connectors.kafka.version>
+ <pekko.management.version>1.0.0</pekko.management.version>
<scala.binary.version>2.13</scala.binary.version>
<!-- needs to be defined to allow for overriding through mvn exec:exec -DAPP_CONFIG=local1.conf -->
<APP_CONFIG>application.conf</APP_CONFIG>
<!-- Version of the Docker image is derived from git commit.
It can be defined with -Dversion.number=0.1-SNAPSHOT if git is not used -->
<version.number>${git.commit.time}-${git.commit.id.abbrev}</version.number>
- <!-- tag::akka-persistence-cassandra[] -->
+ <!-- tag::pekko-persistence-cassandra[] -->
</properties>
- <!-- end::akka-persistence-cassandra[] -->
+ <!-- end::pekko-persistence-cassandra[] -->
- <dependencyManagement>
Review Comment:
I didn't find it similar at first. Get it now, thanks.
```shell
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-bom_${scala.binary.version}</artifactId>
<version>${pekko.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Migrate shopping-cart-service-cassandra-java [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/66#discussion_r1435791268
##########
docs-source/docs/modules/how-to/examples/shopping-cart-service-cassandra-java/docker-compose.yml:
##########
@@ -10,7 +10,7 @@ services:
timeout: 5s
retries: 60
# This exists to force the condition of having the Cassandra service is up before starting the tests.
- # The healthcheck above is not enough because it does not provide a condition to wait for the service
+ # The health-check above is not enough because it does not provide a condition to wait for the service
Review Comment:
Can you revert this? This is worse with a hyphen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org