[GitHub] [daffodil] mike-mcgann commented on pull request #919: Refactor for OSGI compliance

["mike-mcgann (via GitHub)" <gi...@apache.org>]

mike-mcgann commented on PR #919:
URL: https://github.com/apache/daffodil/pull/919#issuecomment-1419320520

   > The first commit's diff looks good except for one thing. Rat.scala is changed in both this commit and the next commit. 
   
   I went back and fixed that so that the script adds them. 
   
   > You also may need to configure your IDE so that it always appends a newline as the final character in files. My git diff complained about there being no newline at the end of the following files:
   
   I fixed the settings in both editors. Hopefully scalafmt will take care of that in the future. 
   
   > The second commit's diffs look like what I saw before, although I noticed this time that some methods had a local `import NodeInfo._` statement in their bodies which was turned into an `import org.apache.daffodil.runtime1.dpath.NodeInfo._` even though there was already an `import org.apache.daffodil.runtime1.dpath.NodeInfo` at the beginning of these files. These methods could have kept their original `import NodeInfo._` local statements without needing to qualify the import. I also saw one `import InfosetEventKind._` get turned into `import org.apache.daffodil.runtime1.infoset.InfosetEventKind._`.
   
   I removed those from the script. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org