[jira] [Commented] (SUREFIRE-1553) @Unroll forces usage of JUnit Vintage

["Sergey Skryabin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033542#comment-17033542 ] 

Sergey Skryabin commented on SUREFIRE-1553:
-------------------------------------------

Hello. Out of curiosity, I've updated
{code:java}
<groupId>org.spockframework</groupId>
<artifactId>spock-core</artifactId>
{code}
from `1.1-groovy-2.4` to `2.0-M1-groovy-2.5`
(it also required updating junit from `5.2.0` to `5.6.0`).

As the result `TEST-JUnit Vintage.xml` -> `TEST-CalculatorSpockTest.xml` (please note package name drop).

If along with that update maven-surefire-plugin from `2.22.0` to `3.0.0-M4` it becomes `TEST-com.skrser.surefire.test.CalculatorSpockTest.xml`. However instead of proper testcase names I see placeholders

{code:java}
Multiply: #a * #b = #expectedResult(Object,Object,Object)
{code}


> @Unroll forces usage of JUnit Vintage
> -------------------------------------
>
>                 Key: SUREFIRE-1553
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1553
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 5.x support, Maven Surefire Plugin
>    Affects Versions: 2.22.0
>            Reporter: Sergey Skryabin
>            Assignee: Tibor Digana
>            Priority: Major
>
> If run
> {code}mvn clean test{code}
> JUnit4 tests and Spock tests (which not contain @Unroll) are executed normally. Once Spock test with @Unroll annotation appears, then Surefire execute
> {code}[INFO] Running JUnit Vintage{code}
>  and all other JUnit4 tests and Spock tests are wrapped with this runner. 
> In surefire-reports I see _TEST-<all tests executed before meeting @Unroll>.xml_ s and than
> _TEST-JUnit Vintage.xml_
> Though it could be done by intention, behaviour is different from 2.21.0 (no wrapping with Vintage). Also it much more visible to have separate reports per test class (both in console output and surefire-reports folder).
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)