You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/04/11 18:56:38 UTC
[kudu-CR] [mini-sentry] do not run the "store-cleaner" thread
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12995
Change subject: [mini-sentry] do not run the "store-cleaner" thread
......................................................................
[mini-sentry] do not run the "store-cleaner" thread
In our MiniSentry-based tests we don't need to clean up the store since
the tests are run from a clean state anyway. Not starting an extra
thread slightly improves startup times. In my experiments about the
improvement was about ~100 milliseconds with the total startup time
to hover around 14 seconds.
In addition, this patch contains an update to always report on Sentry
startup times. Prior to this patch, that report appeared only if
it took more than half of the configured timeout interval for Sentry's
startup.
Change-Id: I908d00d93a9f4cf632899da863275dd01b4a2fad
---
M src/kudu/sentry/mini_sentry.cc
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/12995/1
--
To view, visit http://gerrit.cloudera.org:8080/12995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I908d00d93a9f4cf632899da863275dd01b4a2fad
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-sentry] do not run the "store-cleaner" thread
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12995 )
Change subject: [mini-sentry] do not run the "store-cleaner" thread
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908d00d93a9f4cf632899da863275dd01b4a2fad
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Apr 2019 22:08:36 +0000
Gerrit-HasComments: No
[kudu-CR] [mini-sentry] do not run the "store-cleaner" thread
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12995 )
Change subject: [mini-sentry] do not run the "store-cleaner" thread
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908d00d93a9f4cf632899da863275dd01b4a2fad
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Apr 2019 22:58:01 +0000
Gerrit-HasComments: No
[kudu-CR] [mini-sentry] do not run the "store-cleaner" thread
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12995 )
Change subject: [mini-sentry] do not run the "store-cleaner" thread
......................................................................
[mini-sentry] do not run the "store-cleaner" thread
In our MiniSentry-based tests we don't need to clean up the store since
the tests are run from a clean state anyway. Not starting an extra
thread slightly improves startup times. In my experiments about the
improvement was about ~100 milliseconds with the total startup time
to hover around 14 seconds.
In addition, this patch contains an update to always report on Sentry
startup times. Prior to this patch, that report appeared only if
it took more than half of the configured timeout interval for Sentry's
startup.
Change-Id: I908d00d93a9f4cf632899da863275dd01b4a2fad
Reviewed-on: http://gerrit.cloudera.org:8080/12995
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/sentry/mini_sentry.cc
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I908d00d93a9f4cf632899da863275dd01b4a2fad
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)