You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pradeep Kamath (JIRA)" <ji...@apache.org> on 2009/04/23 21:31:30 UTC

[jira] Created: (PIG-775) PORelationToExprProject should create a NonSpillableDataBag to create empty bags

PORelationToExprProject should create a NonSpillableDataBag to create empty bags
--------------------------------------------------------------------------------

                 Key: PIG-775
                 URL: https://issues.apache.org/jira/browse/PIG-775
             Project: Pig
          Issue Type: Bug
    Affects Versions: 0.2.0
            Reporter: Pradeep Kamath
            Assignee: Pradeep Kamath
            Priority: Minor
             Fix For: 0.3.0


PORelationToExprProject currently uses "BagFactory.newDefaultBag()" to create an empty bag in cases where it has to send an empty bag on EOP - each such empty bag created will be registered with the SpillableMemoryManager as a spillable bag. Since it is an empty bag, it really should not be registered as a spillable bag. For this, NonSpillableDataBag can be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-775) PORelationToExprProject should create a NonSpillableDataBag to create empty bags

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath resolved PIG-775.
--------------------------------

    Resolution: Fixed

Patch committed.

> PORelationToExprProject should create a NonSpillableDataBag to create empty bags
> --------------------------------------------------------------------------------
>
>                 Key: PIG-775
>                 URL: https://issues.apache.org/jira/browse/PIG-775
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: PIG-775.patch
>
>
> PORelationToExprProject currently uses "BagFactory.newDefaultBag()" to create an empty bag in cases where it has to send an empty bag on EOP - each such empty bag created will be registered with the SpillableMemoryManager as a spillable bag. Since it is an empty bag, it really should not be registered as a spillable bag. For this, NonSpillableDataBag can be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-775) PORelationToExprProject should create a NonSpillableDataBag to create empty bags

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-775:
-------------------------------

    Attachment: PIG-775.patch

Attached patch with changes suggested in the description of the issue. The patch also has unit test cases. 

> PORelationToExprProject should create a NonSpillableDataBag to create empty bags
> --------------------------------------------------------------------------------
>
>                 Key: PIG-775
>                 URL: https://issues.apache.org/jira/browse/PIG-775
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: PIG-775.patch
>
>
> PORelationToExprProject currently uses "BagFactory.newDefaultBag()" to create an empty bag in cases where it has to send an empty bag on EOP - each such empty bag created will be registered with the SpillableMemoryManager as a spillable bag. Since it is an empty bag, it really should not be registered as a spillable bag. For this, NonSpillableDataBag can be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-775) PORelationToExprProject should create a NonSpillableDataBag to create empty bags

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702183#action_12702183 ] 

Alan Gates commented on PIG-775:
--------------------------------

+1

> PORelationToExprProject should create a NonSpillableDataBag to create empty bags
> --------------------------------------------------------------------------------
>
>                 Key: PIG-775
>                 URL: https://issues.apache.org/jira/browse/PIG-775
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: PIG-775.patch
>
>
> PORelationToExprProject currently uses "BagFactory.newDefaultBag()" to create an empty bag in cases where it has to send an empty bag on EOP - each such empty bag created will be registered with the SpillableMemoryManager as a spillable bag. Since it is an empty bag, it really should not be registered as a spillable bag. For this, NonSpillableDataBag can be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.