[jira] Commented: (HADOOP-4189) HADOOP-3245 is incomplete

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631866#action_12631866 ] 

Hadoop QA commented on HADOOP-4189:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12390243/HADOOP-4189-v2.patch
  against trunk revision 696228.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3285/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3285/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3285/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3285/console

This message is automatically generated.

> HADOOP-3245 is incomplete
> -------------------------
>
>                 Key: HADOOP-4189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4189
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4189-v1.patch, HADOOP-4189-v2.patch, HADOOP-4189.patch
>
>
> There are 2 issues with HADOOP-3245
> - The default block size for the history files in hadoop-default.conf is set to 0. This file will be empty throughout. It should be made null.
> - Same goes for the buffer size. 
> - InterTrackerProtocol version needs to be bumped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.