You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Kunal8954 (via GitHub)" <gi...@apache.org> on 2026/09/08 01:43:18 UTC
[PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Kunal8954 opened a new pull request, #43978:
URL: https://github.com/apache/superset/pull/43978
The Date Range filter's calendar popup was getting clipped at 100% browser zoom. Turned out that when the filter bar gets narrow enough, the Date Range filter gets pushed into the "More filters" overflow dropdown โ and that dropdown caps its content at 500px height. The calendar was being mounted inside that dropdown instead of directly on document.body, so anything taller than 500px (which a calendar almost always is) got cut off.
At 75%+ zoom the filter still fits in the bar, so it never enters the overflow dropdown, and the calendar mounts to document.body like normal โ which is why it looked fine there.
Fix is small: just always mount the calendar popup to document.body, regardless of whether the filter is overflowing or not. Matches how it already behaves in the non-overflow case.
Tested by shrinking the filter bar so Date Range falls into overflow, opening it at 100% zoom, and confirming the full calendar renders without being clipped.
Fixes #43897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3958700902
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
โ
**Customized review instruction saved!**
**Instruction:**
> Do not flag mounting the Date Range filter popover to document.body; this is intentional to prevent clipping inside the overflow dropdown.
**Applied to:**
- `superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx`
---
๐ก *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43978:
URL: https://github.com/apache/superset/pull/43978#issuecomment-5578159700
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.81%. Comparing base ([`1fb6b98`](https://app.codecov.io/gh/apache/superset/commit/1fb6b98941345a99b12240f482dcbd72caadd34e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5749465`](https://app.codecov.io/gh/apache/superset/commit/5749465a368df3ed2d9d8dccb202872ddca0a278?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43978 +/- ##
==========================================
- Coverage 79.81% 79.81% -0.01%
==========================================
Files 2914 2914
Lines 170470 170468 -2
Branches 39518 39516 -2
==========================================
- Hits 136060 136057 -3
- Misses 31888 31889 +1
Partials 2522 2522
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.36% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43978?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43978:
URL: https://github.com/apache/superset/pull/43978#issuecomment-5577819058
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43978:
URL: https://github.com/apache/superset/pull/43978#issuecomment-5593951728
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43978:
URL: https://github.com/apache/superset/pull/43978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3953640255
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Stale tests fail CI</b></div>
<div id="fix">
This change makes the popover always attach to `document.body`, but the existing tests in `DateFilterLabel.test.tsx` (lines 166-201) still assert that when `isOverflowingFilterBar` is true the popover attaches to `trigger.parentElement`. Those tests will now fail in CI. Please update them to reflect the new always-`document.body` behavior.
</div>
</div>
<small><i>Code Review Run #7648f7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43978:
URL: https://github.com/apache/superset/pull/43978#issuecomment-5577856562
<!-- Bito Reply -->
The flagged issue is correct. By unconditionally setting `getPopupContainer` to `document.body`, the component ignores the `isOverflowingFilterBar` logic that previously scoped the popup container to the parent node when overflowing. This bypasses the intended stacking context and causes overflow tests to fail.
To resolve this, restore the conditional logic for `getPopupContainer` to ensure the popup is scoped correctly based on the overflow state:
```tsx
getPopupContainer={nodeTrigger =>
isOverflowingFilterBar
? (nodeTrigger.parentNode as HTMLElement)
: document.body
}
```
I have validated this fix against the provided diff. Would you like me to fetch all other comments on this PR to check if you want to address them as well?
**superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx**
```
getPopupContainer={nodeTrigger =>
isOverflowingFilterBar
? (nodeTrigger.parentNode as HTMLElement)
: document.body
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43978:
URL: https://github.com/apache/superset/pull/43978#issuecomment-5581078135
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "Kunal8954 (via GitHub)" <gi...@apache.org>.
Kunal8954 commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3958696977
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
Thanks for the review. Mounting to `document.body` is intentional: when a Date Range filter is pushed into the overflow dropdown, that dropdown caps its panel at `MAX_HEIGHT = 500px` with `overflow: auto` (DropdownContainer.tsx:366). The outer popover was previously attached to the trigger parent inside that dropdown, so the calendar (>500px tall) got clipped. Attaching to `document.body` escapes the cap and is the established convention across the codebase (SemanticLayerModal, TagModal, DatabaseModal, SqlLab SaveDatasetModal, FilterCard), and `ControlPopover` already falls back to `document.body` (ControlPopover.tsx:141). The `min(600px, calc(100vw - 32px))` width is vw-relative, so it still resolves against the iframe viewport. The now-redundant inner `getPopupContainer` conditionals in `CustomFrame` are removed in a follow-up commit.
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
The overflow tests were updated in commit `5749465a36` to assert the new behavior (popup attaches to `document.body` even when overflowing), and both `DateFilterLabel.test.tsx` and `CustomFrame.test.tsx` pass (28/28). The suggested conditional would reintroduce the clipping this PR fixes: when `isOverflowingFilterBar` is true, `trigger.parentNode` resolves inside the 500px overflow dropdown, clipping the calendar. Since the outer popover now always mounts to `document.body`, that branch is unreachable and has been removed from `CustomFrame`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3953636714
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
**Suggestion:** This unconditional body container overrides the overflow-specific container contract, causing existing overflow tests to fail and bypassing the dropdown's scoped stacking context. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=17f0b4978b0b482f8caaeacf935d009b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=17f0b4978b0b482f8caaeacf935d009b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
**Line:** 371:371
**Comment:**
*Api Mismatch: This unconditional body container overrides the overflow-specific container contract, causing existing overflow tests to fail and bypassing the dropdown's scoped stacking context.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43978&comment_hash=59029ceaddf61c34ddddc4cac60880fc0a73c587135c91aae814d0673d24bfda&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43978&comment_hash=59029ceaddf61c34ddddc4cac60880fc0a73c587135c91aae814d0673d24bfda&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): stop Date Range calendar popup from clipping in overflow dropdown [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3958700146
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
<!-- Bito Reply -->
The suggestion is correct in its assessment that the previous tests relied on the `isOverflowingFilterBar` logic, which has been removed. Since the popover now consistently attaches to `document.body`, the tests should be updated to remove the conditional logic and assert the new behavior directly. This ensures the test suite remains accurate and passes in the CI environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org