You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2017/06/28 00:47:19 UTC
kafka git commit: MINOR: Adjust checkstyle suppression paths to work
on Windows
Repository: kafka
Updated Branches:
refs/heads/trunk 1d28e2574 -> a293e1dc0
MINOR: Adjust checkstyle suppression paths to work on Windows
Use the file name whenever possible and replace / with [/\\]
when it's not.
Also remove unnecessary suppresions.
Author: Ismael Juma <is...@juma.me.uk>
Reviewers: Vahid Hashemian <va...@us.ibm.com>, Jason Gustafson <ja...@confluent.io>
Closes #3431 from ijuma/fix-checkstyle-suppressions-on-windows
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/a293e1dc
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/a293e1dc
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/a293e1dc
Branch: refs/heads/trunk
Commit: a293e1dc0c0cdc6620abb3c8e099f29772e3d688
Parents: 1d28e25
Author: Ismael Juma <is...@juma.me.uk>
Authored: Wed Jun 28 01:47:00 2017 +0100
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Wed Jun 28 01:47:00 2017 +0100
----------------------------------------------------------------------
checkstyle/suppressions.xml | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/a293e1dc/checkstyle/suppressions.xml
----------------------------------------------------------------------
diff --git a/checkstyle/suppressions.xml b/checkstyle/suppressions.xml
index d21daf1..5c00ede 100644
--- a/checkstyle/suppressions.xml
+++ b/checkstyle/suppressions.xml
@@ -6,17 +6,19 @@
<suppressions>
+ <!-- Note that [/\\] must be used as the path separator for cross-platform support -->
+
<!-- Clients -->
<suppress checks="ClassFanOutComplexity"
files="(Fetcher|Sender|SenderTest|ConsumerCoordinator|KafkaConsumer|KafkaProducer|SaslServerAuthenticator|Utils|TransactionManagerTest|KafkaAdminClient|NetworkClient).java"/>
<suppress checks="ClassFanOutComplexity"
- files=".*/protocol/Errors.java"/>
+ files="Errors.java"/>
<suppress checks="ClassFanOutComplexity"
- files=".*/common/utils/Utils.java"/>
+ files="Utils.java"/>
<suppress checks="ClassFanOutComplexity"
- files=".*/requests/AbstractRequest.java"/>
+ files="AbstractRequest.java"/>
<suppress checks="ClassFanOutComplexity"
- files=".*/requests/AbstractResponse.java"/>
+ files="AbstractResponse.java"/>
<suppress checks="MethodLength"
files="KerberosLogin.java|RequestResponseTest.java"/>
@@ -37,13 +39,13 @@
<suppress checks="ClassDataAbstractionCoupling"
files="(KafkaConsumer|ConsumerCoordinator|Fetcher|KafkaProducer|AbstractRequest|AbstractResponse|TransactionManager|KafkaAdminClient).java"/>
<suppress checks="ClassDataAbstractionCoupling"
- files=".*/protocol/Errors.java"/>
+ files="Errors.java"/>
<suppress checks="BooleanExpressionComplexity"
files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData).java"/>
<suppress checks="CyclomaticComplexity"
- files="(ConsumerCoordinator|Fetcher|Sender|KafkaProducer|BufferPool|ConfigDef|RecordAccumulator|SsLTransportLayer|KerberosLogin|AbstractRequest|AbstractResponse|Selector|SslTransportLayer).java"/>
+ files="(ConsumerCoordinator|Fetcher|Sender|KafkaProducer|BufferPool|ConfigDef|RecordAccumulator|KerberosLogin|AbstractRequest|AbstractResponse|Selector|SslTransportLayer).java"/>
<suppress checks="JavaNCSS"
files="AbstractRequest.java|KerberosLogin.java"/>
@@ -157,9 +159,7 @@
files="KStreamWindowAggregateTest.java"/>
<suppress checks="ClassDataAbstractionCoupling"
- files=".*/streams/.*/Test.java"/>
- <suppress checks="ClassDataAbstractionCoupling"
- files=".*/streams/.*test/.*.java"/>
+ files=".*[/\\]streams[/\\].*test[/\\].*.java"/>
<suppress checks="BooleanExpressionComplexity"
files="SmokeTestDriver.java"/>