You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/01 14:24:21 UTC
[GitHub] [nifi] jlpedrosa opened a new pull request #4856: Add NET_BIND_SERVICE capability to Java in Docker image
jlpedrosa opened a new pull request #4856:
URL: https://github.com/apache/nifi/pull/4856
#### Description of PR
By setting the capability NET_BIND_SERVICE to the java process, users can specify a low port for any of the listeners,
without requiring more privileges or running as root.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes? (Does not apply)
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jlpedrosa closed pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
jlpedrosa closed pull request #4856:
URL: https://github.com/apache/nifi/pull/4856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jlpedrosa commented on pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
jlpedrosa commented on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-800408823
Just a clarification. Adding the capability to the process, it does NOT allow the pod immediately to bind to a low port, on top of this change, the user needs to create the container (or pod if running in k8s), with that capability. So this change is a requirement to bind to low ports, but it won't be enabled by default, users needs to allow it on the container level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #4856: Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-788139219
@jlpedrosa Can you open a JIRA for this at http://issues.apache.org/jira/browse/NIFI ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jlpedrosa removed a comment on pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
jlpedrosa removed a comment on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-788156845
> @jlpedrosa Can you open a JIRA for this at http://issues.apache.org/jira/browse/NIFI ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jlpedrosa commented on pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
jlpedrosa commented on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-788156845
> @jlpedrosa Can you open a JIRA for this at http://issues.apache.org/jira/browse/NIFI ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-880289292
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4856:
URL: https://github.com/apache/nifi/pull/4856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jlpedrosa commented on pull request #4856: Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
jlpedrosa commented on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-788086583
CI Failed to `"failed for https://maven.java.net/content/repositories/snapshots/org/glassfish/javax.el/3.0.1-b08-SNAPSHOT/javax.el-3.0.1-b08-SNAPSHOT.pom 503 Service Unavailable: Back-end server is at capacity"`
Which I don't think it's related to the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4856: NIFI-8275 Add NET_BIND_SERVICE capability to Java in Docker image
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4856:
URL: https://github.com/apache/nifi/pull/4856#issuecomment-788158329
it is not uncommon for spurious artifact collection failures to mess those up. It usually still passes on other builds within the same run though so generally not a big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org