You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/02 17:21:39 UTC

[jira] [Commented] (STORM-733) ShellBolts that don't respond to heartbeats are not being killed

    [ https://issues.apache.org/jira/browse/STORM-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128487#comment-15128487 ] 

ASF GitHub Bot commented on STORM-733:
--------------------------------------

Github user reembs commented on the pull request:

    https://github.com/apache/storm/pull/489#issuecomment-178667030
  
    @HeartSaVioR I see the original bug was already fixed. I like the PR code better, but that's esthetics. Not worth the hassle, Closing.


> ShellBolts that don't respond to heartbeats are not being killed
> ----------------------------------------------------------------
>
>                 Key: STORM-733
>                 URL: https://issues.apache.org/jira/browse/STORM-733
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-multilang
>    Affects Versions: 0.9.3
>            Reporter: Re'em Bensimhon
>            Assignee: Re'em Bensimhon
>            Priority: Critical
>
> In cases where a multilang bolt is stuck (say, an infinite loop), the heartbeats are supposed to detect the issue and kill the supervisor process.
> In 0.9.3 this doesn't happen due to backtype.storm.utils.ShellProcess.getErrorsString() call in ShellBolt.die()
> This call, which in turn executes IOUtils.toString(processErrorStream) will block the thread until process exits. Heartbeat flow should not assume process had exited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)