You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/04/17 14:23:23 UTC

Review Request 20446: Flume agent should be selectable in agents table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20446/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-5491
    https://issues.apache.org/jira/browse/AMBARI-5491


Repository: ambari


Description
-------

Flume service summary has agents table. User should be able to select an agent in the table. The selected agent should be highlighted so that user understands it is selected (see vertex selection in table of Hive+Tez job details page).
When an agent is selected, the title of the Metrics panel should change to Metrics - <agent-name>.
This selected agent property will be used to show other things about the agent.


Diffs
-----

  ambari-web/app/styles/application.less c24866f 
  ambari-web/app/templates/main/service/info/summary.hbs 04729e5 
  ambari-web/app/templates/main/service/services/flume.hbs 6f0ffb6 
  ambari-web/app/views/main/service/info/summary.js 110898f 
  ambari-web/app/views/main/service/services/flume.js a249c7f 

Diff: https://reviews.apache.org/r/20446/diff/


Testing
-------


Thanks,

Aleksandr Kovalenko


Re: Review Request 20446: Flume agent should be selectable in agents table

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20446/#review40641
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On April 17, 2014, 12:23 p.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20446/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 12:23 p.m.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-5491
>     https://issues.apache.org/jira/browse/AMBARI-5491
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Flume service summary has agents table. User should be able to select an agent in the table. The selected agent should be highlighted so that user understands it is selected (see vertex selection in table of Hive+Tez job details page).
> When an agent is selected, the title of the Metrics panel should change to Metrics - <agent-name>.
> This selected agent property will be used to show other things about the agent.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/application.less c24866f 
>   ambari-web/app/templates/main/service/info/summary.hbs 04729e5 
>   ambari-web/app/templates/main/service/services/flume.hbs 6f0ffb6 
>   ambari-web/app/views/main/service/info/summary.js 110898f 
>   ambari-web/app/views/main/service/services/flume.js a249c7f 
> 
> Diff: https://reviews.apache.org/r/20446/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>


Re: Review Request 20446: Flume agent should be selectable in agents table

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20446/
-----------------------------------------------------------

(Updated April 17, 2014, 12:23 p.m.)


Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-5491
    https://issues.apache.org/jira/browse/AMBARI-5491


Repository: ambari


Description
-------

Flume service summary has agents table. User should be able to select an agent in the table. The selected agent should be highlighted so that user understands it is selected (see vertex selection in table of Hive+Tez job details page).
When an agent is selected, the title of the Metrics panel should change to Metrics - <agent-name>.
This selected agent property will be used to show other things about the agent.


Diffs
-----

  ambari-web/app/styles/application.less c24866f 
  ambari-web/app/templates/main/service/info/summary.hbs 04729e5 
  ambari-web/app/templates/main/service/services/flume.hbs 6f0ffb6 
  ambari-web/app/views/main/service/info/summary.js 110898f 
  ambari-web/app/views/main/service/services/flume.js a249c7f 

Diff: https://reviews.apache.org/r/20446/diff/


Testing
-------


Thanks,

Aleksandr Kovalenko