[jira] Issue Comment Edited: (OFBIZ-3381) Update of the geolocation screen in party

["Bruno Busco (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794548#action_12794548 ] 

Bruno Busco edited comment on OFBIZ-3381 at 12/26/09 8:24 AM:
--------------------------------------------------------------

Erwan,
there are two things I do not like in the patch:
1) (minor) Since we have the PartyGeoLocation.groovy script executed I would move all the <set...> stuff in there and have a complete geoChart valorization in the groovy.

2) (major) In the geolocation.ftl I would not include this:
{code}
<#if point.partyId?has_content>
  marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=<@o...@ofbizUrl>>${uiLabelMap.PartyProfile} ${uiLabelMap.CommonOf} ${point.partyId}</a></div>");
</#if>
{code}

because it introduces a (soft) framework dependance from the Party component.
I would replace it with a more generic:

{code}
<#if point.link?has_content>
  marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=${point.link.url}>${point.link.label}</a></div>");
</#if>
{code}


      was (Author: bruno.busco):
    Erwan,
there are two things I do not like in the patch:
1) (minor) Since we have the PartyGeoLocation.groovy script executed I would move all the <set...> stuff in there and have a complete geoChart valorization in the groovy.

2) (major) In the geolocation.ftl I would not include this:
{code}
<#if point.partyId?has_content>
  marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=<@o...@ofbizUrl>>${uiLabelMap.PartyProfile} ${uiLabelMap.CommonOf} ${point.partyId}</a></div>");
</#if>
{code}

because it introduces a (soft) framework dependance from the Party component.
I would replace it with a more generic:

{code}
<#if point.link?has_content>
  marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=${point.link.url}>${point.link.label}</a></div>");
</#if>
{code}

BTW:
I only watched at the code. I did not succeded to show any map screen even for the DemoCustomer. I always get the "No Geolocation Available (for a demo you may try using DemoCustomer party profil)" message.
  
> Update of the geolocation screen in party
> -----------------------------------------
>
>                 Key: OFBIZ-3381
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3381
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3381.diff
>
>
> This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls.
> I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements.
> if it's OK, I will then commit it to the trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.