You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by keith-turner <gi...@git.apache.org> on 2016/08/12 22:46:38 UTC
[GitHub] incubator-fluo pull request #761: Found and fixed two bugs while working on ...
GitHub user keith-turner opened a pull request:
https://github.com/apache/incubator-fluo/pull/761
Found and fixed two bugs while working on the Fluo Tour.
* Threads were not shutting down
* Multiple collisions of non trigger node was failing in commit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith-turner/fluo tour-bugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fluo/pull/761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #761
----
commit 468d1cfc4bf43a49c5c7ffb2188ad67b62cc2d0d
Author: Keith Turner <kt...@apache.org>
Date: 2016-08-12T22:44:40Z
Found and fixed two bugs while working on the Fluo Tour.
* Threads were not shutting down
* Multiple collisions of non trigger node was failing in commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo issue #761: Found and fixed two bugs while working on the Flu...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/incubator-fluo/pull/761
The changes look good to me. Do you know why tests are failing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo pull request #761: Found and fixed two bugs while working on ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fluo/pull/761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo issue #761: Found and fixed two bugs while working on the Flu...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/incubator-fluo/pull/761
If you mean Jenkins, it's been having a lot of problems lately, like not being able to resolve dependencies, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo issue #761: Found and fixed two bugs while working on the Flu...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/incubator-fluo/pull/761
I was talking about TravisCI which looks like it has tests that are failing and not dep issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo issue #761: Found and fixed two bugs while working on the Flu...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/incubator-fluo/pull/761
I was able to run mvn verify 3 times successfully against this branch. I am not sure why that test failed, I opened an issue to look into it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo issue #761: Found and fixed two bugs while working on the Flu...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/incubator-fluo/pull/761
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---