You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/25 08:11:24 UTC

[GitHub] [skywalking] keiranmraine edited a comment on issue #7552: [License-Eye] pyx files (cython)

keiranmraine edited a comment on issue #7552:
URL: https://github.com/apache/skywalking/issues/7552#issuecomment-905281672


   According to the current main branch the `.pyx` extension is supported:
   
   https://github.com/apache/skywalking-eyes/blob/082ccc7d63f8cde9afdb6eee30843b8f0a8182ed/assets/languages.yaml#L1090
   
   It appears that although it works for `check` it fails for `fix:
   
   `check` - identifies file needs update:
   
   ```
   docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
   ...
   INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0 
   ERROR the following files don't have a valid license header: 
   pygas/matrix.pyx 
   ```
   
   `fix` - indicates unsupported:
   
   ```
   docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
   INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0 
   ERROR unsupported file: pygas/matrix.pyx
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org