You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/01/05 12:16:45 UTC
Re: Review Request 41548: [3/5] Quota Authorization: Implemented quota
remove authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 12:16 p.m.)
Review request for mesos, Alexander Rukletsov and Till Toenshoff.
Changes
-------
Addressed issues.
Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081
Repository: mesos
Description
-------
Quota Authorization: Implemented quota remove authorization.
Diffs (updated)
-----
include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9
src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498
Diff: https://reviews.apache.org/r/41548/diff/
Testing (updated)
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 41548: [3/5] Quota Authorization: Implemented quota
remove authorization.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/#review112843
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 5, 2016, 11:16 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41548/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:16 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4081
> https://issues.apache.org/jira/browse/MESOS-4081
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota Authorization: Implemented quota remove authorization.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9
> src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498
>
> Diff: https://reviews.apache.org/r/41548/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 41548: [3/5] Quota Authorization: Implemented quota
remove authorization.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/#review112884
-----------------------------------------------------------
src/master/master.hpp (lines 1009 - 1010)
<https://reviews.apache.org/r/41548/#comment173362>
Snake case?!
src/master/quota_handler.cpp (line 341)
<https://reviews.apache.org/r/41548/#comment173360>
This is rather confusing to me.
Above we created a convenience reference to `create.get()` named `quotaInfo`. Now you are mutating that `create.get()` result directly.
How about making `quotaInfo` above a copy (instead of a reference) and then modifying that one here, if needed?
src/master/quota_handler.cpp (lines 524 - 525)
<https://reviews.apache.org/r/41548/#comment173361>
No snake case here please!
- Till Toenshoff
On Jan. 5, 2016, 11:16 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41548/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:16 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4081
> https://issues.apache.org/jira/browse/MESOS-4081
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota Authorization: Implemented quota remove authorization.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9
> src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498
>
> Diff: https://reviews.apache.org/r/41548/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 41548: Quota: Implemented quota remove
authorization.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/#review113075
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 6, 2016, 2:37 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41548/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:37 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4081
> https://issues.apache.org/jira/browse/MESOS-4081
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota Authorization: Implemented quota remove authorization.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto ab505b1a8b99e2ec0b541cd258daabc8d8045191
> src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec
> src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9
>
> Diff: https://reviews.apache.org/r/41548/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 41548: Quota: Implemented quota remove
authorization.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:37 p.m.)
Review request for mesos, Alexander Rukletsov and Till Toenshoff.
Summary (updated)
-----------------
Quota: Implemented quota remove authorization.
Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081
Repository: mesos
Description
-------
Quota Authorization: Implemented quota remove authorization.
Diffs
-----
include/mesos/quota/quota.proto ab505b1a8b99e2ec0b541cd258daabc8d8045191
src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec
src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9
Diff: https://reviews.apache.org/r/41548/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 41548: [3/5] Quota Authorization: Implemented quota
remove authorization.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 12:16 p.m.)
Review request for mesos, Alexander Rukletsov and Till Toenshoff.
Changes
-------
Addressed issues.
Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081
Repository: mesos
Description
-------
Quota Authorization: Implemented quota remove authorization.
Diffs (updated)
-----
include/mesos/quota/quota.proto ab505b1a8b99e2ec0b541cd258daabc8d8045191
src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec
src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9
Diff: https://reviews.apache.org/r/41548/diff/
Testing
-------
make check
Thanks,
Jan Schlicht