You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/09 13:41:15 UTC

[GitHub] [avro] RyanSkraba opened a new pull request #978: AVRO-2957: Pin ruby 'parallel' dependency for Ruby 2.3 support

RyanSkraba opened a new pull request #978:
URL: https://github.com/apache/avro/pull/978


   This is the quickest fix I found, but getting rid of the Ruby 2.3 support seems more and more obvious for the next major release! 
   
   ### Jira
   
   - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-2957: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #978: AVRO-2957: Pin ruby 'parallel' dependency for Ruby 2.3 support

Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #978:
URL: https://github.com/apache/avro/pull/978


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] tjwp commented on pull request #978: AVRO-2957: Pin ruby 'parallel' dependency for Ruby 2.3 support

Posted by GitBox <gi...@apache.org>.
tjwp commented on pull request #978:
URL: https://github.com/apache/avro/pull/978#issuecomment-724076504


   I started work on moving the build to 2.5 in https://github.com/apache/avro/pull/929, but I need to get back to looking at the associated build failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] tjwp commented on pull request #978: AVRO-2957: Pin ruby 'parallel' dependency for Ruby 2.3 support

Posted by GitBox <gi...@apache.org>.
tjwp commented on pull request #978:
URL: https://github.com/apache/avro/pull/978#issuecomment-724182018


   @RyanSkraba my concern is more around the commit history once this is merged rather than it being tracked in JIRA, especially for a quick fix.
   
   I think the separate commits should be preserved, however the changes are tracked, so that a PHP build change does not end up "hidden" within a Ruby dependency fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #978: AVRO-2957: Pin ruby 'parallel' dependency for Ruby 2.3 support

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #978:
URL: https://github.com/apache/avro/pull/978#issuecomment-724163110


   @tjwp That's a good question!  I'm trying a couple of fixes -- do you think it's worth doing a new JIRA?
   
   It's probably not the best practice piling the changes on in this one PR, but I'd like to see the "quick fix" applied soon and the "right fix" documented in it's own JIRA!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #978: AVRO-2957: Pin ruby 'parallel' dependency for Ruby 2.3 support

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #978:
URL: https://github.com/apache/avro/pull/978#issuecomment-724121974


   There's still a PHP error (easily reproduceable) ... taking a look.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org