You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/22 20:01:53 UTC
Review Request 37703: Add docker exec command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Add docker exec command.
Diffs
-----
src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e
src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250
src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 30, 2015, 2:30 a.m., Guangya Liu wrote:
> > src/docker/docker.cpp, line 169
> > <https://reviews.apache.org/r/37703/diff/2/?file=1059364#file1059364line169>
> >
> > Why update this? This does not seems to be related to this patch and also the value should be const as the function only read this value.
Because I think it broke the mesos style [here](https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#capture-by-reference). I revert this change now.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review97006
-----------------------------------------------------------
On Aug. 29, 2015, 1:51 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2015, 1:51 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
> src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review97006
-----------------------------------------------------------
src/docker/docker.cpp (line 169)
<https://reviews.apache.org/r/37703/#comment152708>
Why update this? This does not seems to be related to this patch and also the value should be const as the function only read this value.
- Guangya Liu
On Aug. 29, 2015, 1:51 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2015, 1:51 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
> src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review97020
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Aug. 30, 2015, 8:16 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 8:16 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
> src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review98054
-----------------------------------------------------------
src/docker/docker.cpp (line 1200)
<https://reviews.apache.org/r/37703/#comment154265>
4 space indent instead of 8
src/tests/containerizer/docker_tests.cpp (line 241)
<https://reviews.apache.org/r/37703/#comment154264>
Please follow how other tests are testing preconditions, one example:
ASSERT_SOME(
cgroups::memory::oom::killer::enabled(hierarchy, TEST_CGROUPS_ROOT))
<< "-------------------------------------------------------------\n"
<< "We cannot run this test because it appears you do not have\n"
<< "a modern enough version of the Linux kernel. You won't be\n"
<< "able to use the cgroups isolator, but feel free to disable\n"
<< "this test.\n"
<< "-------------------------------------------------------------";
And also move this to the beginning of the test
- Timothy Chen
On Aug. 30, 2015, 8:16 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 8:16 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
> src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review97019
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
All tests passed.
- Mesos ReviewBot
On Aug. 30, 2015, 8:16 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 8:16 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
> src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review98168
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
All tests passed.
- Mesos ReviewBot
On Sept. 9, 2015, 9:15 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 9:15 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403
> src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113626
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp (line 299)
<https://reviews.apache.org/r/37703/#comment174388>
I'll fix this myself, but comments should end with period.
- Timothy Chen
On Jan. 9, 2016, 10:35 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 10:35 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On Jan. 11, 2016, 8:16 a.m., Qian Zhang wrote:
> >
@haosdent, can you please let me know in which case we need to call this "docker exec" command that you added in this patch?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113664
-----------------------------------------------------------
On Jan. 10, 2016, 2:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 2:32 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 11, 2016, 12:16 a.m., Qian Zhang wrote:
> >
>
> Qian Zhang wrote:
> @haosdent, can you please let me know in which case we need to call this "docker exec" command that you added in this patch?
Hi, @qianzhang. So far don't have cases to call `docker exec`. I try to add this before because we want execute health check in docker container through `docker exec`. But currently docker container health check don't depends on this.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113664
-----------------------------------------------------------
On Jan. 11, 2016, 6:01 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 6:01 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113664
-----------------------------------------------------------
src/docker/docker.cpp (line 1229)
<https://reviews.apache.org/r/37703/#comment174421>
s/don't/does not/
s/be/is/
- Qian Zhang
On Jan. 10, 2016, 2:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 2:32 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 6:01 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Address @qianzhang comments
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Jan. 10, 2016, 6:32 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Address @tnachen comment
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 10:35 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Fix fail test case.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 9, 2016, 1:05 a.m., Timothy Chen wrote:
> > I just ran the CheckExec test and it failed for me, can you try it yourself and see if you can repro?
sorry, my bad. Let me update again..
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113582
-----------------------------------------------------------
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113582
-----------------------------------------------------------
I just ran the CheckExec test and it failed for me, can you try it yourself and see if you can repro?
- Timothy Chen
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review109600
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Dec. 9, 2015, 5:42 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Address @tnachen comments.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Dec. 1, 2015, 3:09 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, line 297
> > <https://reviews.apache.org/r/37703/diff/7/?file=1148103#file1148103line297>
> >
> > This isn't enough still, when the future is ready doesn't mean the container is actually running yet.
> >
> > What you could do is to run docker->inspect(containerName, Miliseconds(500)) and it will retry inspect until it's running, then you AWAIT that inspect future.
Thx, let me update.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108445
-----------------------------------------------------------
On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 4:37 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108445
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp (line 297)
<https://reviews.apache.org/r/37703/#comment167905>
This isn't enough still, when the future is ready doesn't mean the container is actually running yet.
What you could do is to run docker->inspect(containerName, Miliseconds(500)) and it will retry inspect until it's running, then you AWAIT that inspect future.
- Timothy Chen
On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 4:37 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108275
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 4:37 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Nov. 29, 2015, 4:37 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Update according to @tnachen's reviews
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review101402
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107682
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Nov. 24, 2015, 1:23 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, line 298
> > <https://reviews.apache.org/r/37703/diff/6/?file=1089376#file1089376line298>
> >
> > This test failed for me since at the time docker->exec is called the container isn't running yet.
> >
> > Please abstract out the exists() method (probably in tests/containerizer/docker_test_helper.hpp) in containerizer_docker_tests so you can use it here that you wait until the container is running before you run docker exec.
Are you refer to the `exists` method in `src/tests/containerizer/docker_containerizer_tests.cpp`? Because could not use it in `src/tests/containerizer/docker_tests.cpp`, I use `AWAIT_READY(status);` directly.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107694
-----------------------------------------------------------
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107694
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp (line 298)
<https://reviews.apache.org/r/37703/#comment166954>
This test failed for me since at the time docker->exec is called the container isn't running yet.
Please abstract out the exists() method (probably in tests/containerizer/docker_test_helper.hpp) in containerizer_docker_tests so you can use it here that you wait until the container is running before you run docker exec.
- Timothy Chen
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 9:09 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Update according @tnachen reviews
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 29, 2015, 1:24 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 1164
> > <https://reviews.apache.org/r/37703/diff/5/?file=1065940#file1065940line1164>
> >
> > We're now supporting optional docker socket (-H), if you look at other commands.
> >
> > Perhaps we should make this into a helper function so we don't have to do this in every command.
Oh, thx. I would update and rebase this at this weekend.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review100914
-----------------------------------------------------------
On Sept. 9, 2015, 9:15 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 9:15 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403
> src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review100914
-----------------------------------------------------------
src/docker/docker.cpp (line 1164)
<https://reviews.apache.org/r/37703/#comment158177>
We're now supporting optional docker socket (-H), if you look at other commands.
Perhaps we should make this into a helper function so we don't have to do this in every command.
- Timothy Chen
On Sept. 9, 2015, 9:15 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 9:15 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403
> src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 9:15 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Fix compile error.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403
src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9
src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 2:27 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Update according @tnachen reviews.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403
src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9
src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Aug. 30, 2015, 8:16 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Aug. 29, 2015, 1:51 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Update according reviews from @tnachen.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 26, 2015, 4:28 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 1077
> > <https://reviews.apache.org/r/37703/diff/1/?file=1047969#file1047969line1077>
> >
> > In what situation would we want to enable tty?
I think not need enable tty. At first I just try to follow docker exec doucment. Now I think we could remove tty and detach here.
> On Aug. 26, 2015, 4:28 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 1091
> > <https://reviews.apache.org/r/37703/diff/1/?file=1047969#file1047969line1091>
> >
> > I'm not sure this is needed since we already want to wrap the command in shell anyways
If execute docker exec container_name "echo foo", docker would return error that could not find command "echo foo". If execute docker exec container_name echo foo, it could works well. So I add "sh -c" here.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review96540
-----------------------------------------------------------
On Aug. 22, 2015, 6:02 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2015, 6:02 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e
> src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review96540
-----------------------------------------------------------
src/docker/docker.cpp (line 1077)
<https://reviews.apache.org/r/37703/#comment151985>
In what situation would we want to enable tty?
src/docker/docker.cpp (line 1082)
<https://reviews.apache.org/r/37703/#comment151984>
put the detach value in another argv push_back, same as the tty
src/docker/docker.cpp (line 1091)
<https://reviews.apache.org/r/37703/#comment151986>
I'm not sure this is needed since we already want to wrap the command in shell anyways
src/tests/containerizer/docker_tests.cpp (line 135)
<https://reviews.apache.org/r/37703/#comment151983>
Can you create a seperate test for exec? And we then do a version check in the test.
- Timothy Chen
On Aug. 22, 2015, 6:02 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2015, 6:02 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e
> src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250
> src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Aug. 22, 2015, 6:02 p.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs
-----
src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e
src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250
src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang