[jira] Resolved: (SHINDIG-1255) NekoSimplifiedHtmlParser doesn't like html comments ()

["John Hjelmstad (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Hjelmstad resolved SHINDIG-1255.
-------------------------------------

    Resolution: Fixed

Committed r898161.

> NekoSimplifiedHtmlParser doesn't like html comments (<!-- ... -->)
> ------------------------------------------------------------------
>
>                 Key: SHINDIG-1255
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1255
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>            Reporter: Jasvir Nagra
>
> To reproduce, render the following gadget:
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
>  <ModulePrefs title="Test" />
>  <Content type="html">
>    <![CDATA[
> <!-- This causes an exception -->
>   ]]>
>   </Content>
> </Module>
> java.lang.NullPointerException
> 	at org.apache.shindig.gadgets.parse.nekohtml.NekoSimplifiedHtmlParser.fixNekoWeirdness(NekoSimplifiedHtmlParser.java:181)
> 	at org.apache.shindig.gadgets.parse.nekohtml.NekoSimplifiedHtmlParser.parseDomImpl(NekoSimplifiedHtmlParser.java:111)
> 	at org.apache.shindig.gadgets.parse.GadgetHtmlParser.parseDom(GadgetHtmlParser.java:97)
> 	at org.apache.shindig.gadgets.rewrite.MutableContent.getDocument(MutableContent.java:134)
> 	at org.apache.shindig.gadgets.servlet.CajaContentRewriter.rewrite(CajaContentRewriter.java:115)
> 	at org.apache.shindig.gadgets.render.HtmlRenderer.render(HtmlRenderer.java:88)
> 	at org.apache.shindig.gadgets.render.Renderer.render(Renderer.java:87)
> 	at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.render(GadgetRenderingServlet.java:70)
> 	at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.doGet(GadgetRenderingServlet.java:112)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> 	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
> 	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
> 	at org.apache.shindig.auth.AuthenticationServletFilter.callChain(AuthenticationServletFilter.java:123)
> 	at org.apache.shindig.auth.AuthenticationServletFilter.doFilter(AuthenticationServletFilter.java:86)
> 	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
> 	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
> 	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> 	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
> 	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
> 	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
> 	at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
> 	at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
> 	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> 	at org.mortbay.jetty.Server.handle(Server.java:326)
> 	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:536)
> 	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:915)
> 	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:539)
> 	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
> 	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:405)
> 	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
> 	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.