You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by vvdb <gi...@git.apache.org> on 2017/08/01 10:24:49 UTC
[GitHub] lucenenet pull request #210: Corrected bug in Lifetime reference count
GitHub user vvdb opened a pull request:
https://github.com/apache/lucenenet/pull/210
Corrected bug in Lifetime reference count
The addFactory in ConcurrentDictionary's GetOrAdd isn't guaranteed to be called only once, yielding incorrect reference counts. Switched to a lazily evaluated singleton to avoid this
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vvdb/lucenenet vincents-amazing-patch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit d2c427e37b593ddfa17c27d5cde8367d48d0ba5c
Author: Vincent Van Den Berghe <vv...@bvdep.com>
Date: 2017-07-30T16:40:47Z
Corrected bug in Lifetime reference count
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #210: Corrected bug in Lifetime reference count
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/210
As you can see your commit is here: https://github.com/apache/lucenenet/commits/master
What you do with the branch on your GitHub account is up to you. Personally, I usually just keep them in case I need to review them later - it is easier to find your commits when they are on top of your own branch than buried among everyone else's. And GitHub won't send you a bill for keeping them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #210: Corrected bug in Lifetime reference count
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/210
Thanks.
I would have thought you would be more creative with the branch name, though.
I pushed this to master, but somehow GitHub didn't get the message and left it open. For whatever reason, I don't have the ability to close pull requests on GitHub from the UI, the only way I can do it is by pushing another commit with a special `#closes 210` commit message. So, if you don't mind (and you can see a close button here), please close this pull request, it is accepted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #210: Corrected bug in Lifetime reference count
Posted by vvdb <gi...@git.apache.org>.
Github user vvdb commented on the issue:
https://github.com/apache/lucenenet/pull/210
Good morning Shad,
I followed your detailed instruction to the letter and was so happy it worked. And “vincents-amazing-patch” sounded creative enough <g>.
I closed the pull request, and got this as a message:
Closed with unmerged commits
This pull request is closed, but the vvdb:vincents-amazing-patch branch has unmerged commits.
… with a button “Delete branch”. I did not click on that button. But can I? If so, next time I’ll have a more creative name, such as vincents-attempt-at-a-pull-requests-waiting-for-Shad-s-approval. Or something like that…
Vincent
From: Shad Storhaug [mailto:notifications@github.com]
Sent: Wednesday, August 02, 2017 8:07 AM
To: apache/lucenenet <lu...@noreply.github.com>
Cc: Van Den Berghe, Vincent <Vi...@bvdinfo.com>; Author <au...@noreply.github.com>
Subject: Re: [apache/lucenenet] Corrected bug in Lifetime reference count (#210)
Thanks.
I would have thought you would be more creative with the branch name, though.
I pushed this to master, but somehow GitHub didn't get the message and left it open. For whatever reason, I don't have the ability to close pull requests on GitHub from the UI, the only way I can do it is by pushing another commit with a special #closes 210 commit message. So, if you don't mind (and you can see a close button here), please close this pull request, it is accepted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/lucenenet/pull/210#issuecomment-319576869>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARBXptBSLCcJVQHf5CnF-D45zdhHCuCHks5sUBIQgaJpZM4Ophnh>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request #210: Corrected bug in Lifetime reference count
Posted by vvdb <gi...@git.apache.org>.
Github user vvdb closed the pull request at:
https://github.com/apache/lucenenet/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---