[jira] [Work logged] (ARTEMIS-2211) Refactor ByteBuffer pooling, alignment and zeroing

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2211?focusedWorklogId=209476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209476 ]

ASF GitHub Bot logged work on ARTEMIS-2211:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Mar/19 09:45
            Start Date: 07/Mar/19 09:45
    Worklog Time Spent: 10m 
      Work Description: franz1981 commented on issue #2479: ARTEMIS-2211 Refactor ByteBuffer pooling, alignment and zeroing
URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-470456911
 
 
   @michaelandrepearce 
   > also whats occuring with the possible leakage has that been addressed
   
   We have 2 leaks with NIO/MAPPED seq factories:
   
   1. on compaction: it has been addressed not in this PR by NOT using `ByteBuffer` pooling ie it will allocate upfront and free the buffers when finished
   2. on paging/while writing on the journal
   
   The second one is due to thread-local `ByteBuffer` pooling + our thread pool + type of load: 
   
   - we have burst of journal activity that will make N threads to be created 
   - the burst of load will finish and more then 1 minute has passed: many threads got disposed, but the thread-pooled `ByteBuffer` will be cleaned up only if a GC will happen, but suppose it won't happen
   - another burst of journal activity will make other N threads to be created
   - we ends up having many `ByteBuffer` instances alive: old ones + new ones
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 209476)
    Time Spent: 1h 50m  (was: 1h 40m)

> Refactor ByteBuffer pooling, alignment and zeroing
> --------------------------------------------------
>
>                 Key: ARTEMIS-2211
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2211
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>             Fix For: 2.7.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)