Re: svn commit: r36156 - trunk

[Greg Stein <gs...@gmail.com>]

Um... that was something like 3 or 4 changes to that ONE line over a
series of a few commits. Are you not testing your changes at all
before you commit? Or doing a pre-commit diff inspection?

It worries me when these kinds of trivial/obvious errors get into the
code as an apparent result of no testing. What will be next? What is
going to get *missed*?

-g

On Thu, Feb 26, 2009 at 14:16, Bert Huijben <rh...@sharpsvn.net> wrote:
> Author: rhuijben
> Date: Thu Feb 26 05:16:48 2009
> New Revision: 36156
>
> Log:
> * win-tests.py
>  (Httpd._start_daemon): Remove an invalid ')' introduced yesterday.
>
> Modified:
>   trunk/win-tests.py
>
> Modified: trunk/win-tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/win-tests.py?pathrev=36156&r1=36155&r2=36156
> ==============================================================================
> --- trunk/win-tests.py  Thu Feb 26 05:01:32 2009        (r36155)
> +++ trunk/win-tests.py  Thu Feb 26 05:16:48 2009        (r36156)
> @@ -524,7 +524,7 @@ class Httpd:
>     try:
>       import win32process
>       import win32con
> -      args = ' '.join([self._quote(x) for x in self.httpd_args)])
> +      args = ' '.join([self._quote(x) for x in self.httpd_args])
>       self.proc_handle = (
>         win32process.CreateProcess(self._quote(self.path), args,
>                                    None, None, 0,
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1232916
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1233320