You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/12 08:53:27 UTC
[GitHub] [dolphinscheduler-website] linjicong opened a new pull request #634: Fix incorrect spelling and path
linjicong opened a new pull request #634:
URL: https://github.com/apache/dolphinscheduler-website/pull/634
Fix incorrect spelling and path
About_DolphinScheduler.md
upgrade.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] linjicong commented on pull request #634: Fix incorrect spelling and path
Posted by GitBox <gi...@apache.org>.
linjicong commented on pull request #634:
URL: https://github.com/apache/dolphinscheduler-website/pull/634#issuecomment-1012727923
I think i need more time to fix all dead links in old version docs.because it cannot pass Dead Link Checker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #634: Fix incorrect spelling and path
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #634:
URL: https://github.com/apache/dolphinscheduler-website/pull/634#discussion_r784719264
##########
File path: site_config/docs2-0-2.js
##########
@@ -279,7 +279,7 @@ export default {
children: [
{
title: '简介',
- link: '/zh-cn/docs/About_DolphinScheduler/About_DolphinScheduler.html',
+ link: '/zh-cn/docs/2.0.2/user_doc/About_DolphinScheduler/About_DolphinScheduler.html',
Review comment:
We should also change dev document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #634: Fix incorrect spelling and path
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #634:
URL: https://github.com/apache/dolphinscheduler-website/pull/634#discussion_r784487381
##########
File path: site_config/docs2-0-0.js
##########
@@ -283,7 +283,7 @@ export default {
children: [
{
title: '简介',
- link: '/zh-cn/docs/About_DolphinScheduler/About_DolphinScheduler.html',
+ link: '/zh-cn/docs/2.0.1/user_doc/About_DolphinScheduler/About_DolphinScheduler.html',
Review comment:
I fond out we still have this file in https://github.com/apache/dolphinscheduler-website/blob/5f4d4a913d0909f36a33c776c1d9cef3adb1ba11/docs/zh-cn/About_DolphinScheduler/About_DolphinScheduler.md could you remove the file. and add it to each verison doc?
##########
File path: site_config/docs2-0-0.js
##########
@@ -283,7 +283,7 @@ export default {
children: [
{
title: '简介',
- link: '/zh-cn/docs/About_DolphinScheduler/About_DolphinScheduler.html',
+ link: '/zh-cn/docs/2.0.1/user_doc/About_DolphinScheduler/About_DolphinScheduler.html',
Review comment:
```suggestion
link: '/zh-cn/docs/2.0.0/user_doc/About_DolphinScheduler/About_DolphinScheduler.html',
```
##########
File path: docs/zh-cn/1.3.8/user_doc/system-manual.md
##########
@@ -0,0 +1,865 @@
+# 系统使用手册
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #634: Fix incorrect spelling and path
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #634:
URL: https://github.com/apache/dolphinscheduler-website/pull/634#issuecomment-1012812368
> I think I need more time to fix all dead links in old version docs. because it cannot pass the Dead Link Checker.
Our dead link checker has some error when you add a new page to it, you could see in https://github.com/apache/dolphinscheduler/issues/7642
I fond out error cause
```log
[✖] https://dolphinscheduler.apache.org/zh-cn/docs/1.3.8/user_doc/system-manual.html → Status: 404
1638
Error: Process completed with exit code 1.
```
And the page you just add it in this PR, so I think is good and we should do nothing about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #634: Fix incorrect spelling and path
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #634:
URL: https://github.com/apache/dolphinscheduler-website/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org