You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aitozi (via GitHub)" <gi...@apache.org> on 2023/04/06 09:27:55 UTC

[GitHub] [flink] Aitozi opened a new pull request, #22363: [FLINK-31301][planner] Add support of nested columns in column list o…

Aitozi opened a new pull request, #22363:
URL: https://github.com/apache/flink/pull/22363

   …f insert statement
   
   ## What is the purpose of the change
   
   This PR is meant to support nested column as the insert target columns like `insert into (r1.a, r2.b) select a, b from src`
   
   ## Verifying this change
   
   - Planner test in `PartialInsertTest`
   - ITTest in `TableSinkITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22363: [FLINK-31301][planner] Add support of nested columns in column list o…

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22363:
URL: https://github.com/apache/flink/pull/22363#issuecomment-1498770369

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "973f44cc1ab126994360bf27a3f10a1552a1ce3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "973f44cc1ab126994360bf27a3f10a1552a1ce3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 973f44cc1ab126994360bf27a3f10a1552a1ce3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #22363: [FLINK-31301][planner] Add support of nested columns in column list o…

Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #22363:
URL: https://github.com/apache/flink/pull/22363#issuecomment-1498810787

   This PR does not support the partition column with nested type, due to it has been limited in `SqlCreateTableConverter#verifyPartitioningColumnsExist`. So the partition column should only work with the top level column now.
   
   ```
    private void verifyPartitioningColumnsExist(Schema mergedSchema, List<String> partitionKeys) {
     Set<String> columnNames =
             mergedSchema.getColumns().stream()
                     .map(Schema.UnresolvedColumn::getName)
                     .collect(Collectors.toCollection(LinkedHashSet::new));
     for (String partitionKey : partitionKeys) {
         if (!columnNames.contains(partitionKey)) {
             throw new ValidationException(
                     String.format(
                             "Partition column '%s' not defined in the table schema. Available columns: [%s]",
                             partitionKey,
                             columnNames.stream()
                                     .collect(Collectors.joining("', '", "'", "'"))));
         }
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Aitozi commented on pull request #22363: [FLINK-31301][planner] Add support of nested columns in column list o…

Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #22363:
URL: https://github.com/apache/flink/pull/22363#issuecomment-1500451435

   @lincoln-lil please take a look when you are free, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org