You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "chenrui333 (via GitHub)" <gi...@apache.org> on 2023/02/12 17:00:50 UTC
[GitHub] [arrow] chenrui333 opened a new pull request, #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
chenrui333 opened a new pull request, #34152:
URL: https://github.com/apache/arrow/pull/34152
Signed-off-by: Rui Chen <ru...@chenrui.dev>
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
`Protobuf_PROTOC_EXECUTABLE` is not valid cmake arg, thus updating it to `PROTOBUF_PROTOC_EXECUTABLE`
```
Manually-specified variables were not used by the project:
BUILD_TESTING
Protobuf_PROTOC_EXECUTABLE
```
### What changes are included in this PR?
Just some CMAKE arg change.
### Are these changes tested?
Yes, tested in my local build with https://github.com/Homebrew/homebrew-core/pull/121566
### Are there any user-facing changes?
Nope
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34152:
URL: https://github.com/apache/arrow/pull/34152#issuecomment-1427081512
:warning: GitHub issue #34151 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34152:
URL: https://github.com/apache/arrow/pull/34152#issuecomment-1427081505
* Closes: #34151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34152:
URL: https://github.com/apache/arrow/pull/34152#issuecomment-1427130198
Thanks for the patch!
But they are needless.
There are 2 `FindProtobuf.cmake`s, `FindProtobuf.cmake` in CMake itself ( https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindProtobuf.cmake ) and `FindProtobuf.cmake` in Apache ORC ( https://github.com/apache/orc/blob/main/cmake_modules/FindProtobuf.cmake ).
The former uses `Protobuf_PROTOC_EXECUTABLE` and the latter uses `PROTOBUF_PROTOC_EXECUTABLE`.
And we already use `PROTOBUF_PROTOC_EXECUTABLE` for Apache ORC: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L4443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34152:
URL: https://github.com/apache/arrow/pull/34152#issuecomment-1432008551
I close this in favor of #34192.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed pull request #34152: GH-34151: update `Protobuf_PROTOC_EXECUTABLE` to `PROTOBUF_PROTOC_EXECUTABLE`
URL: https://github.com/apache/arrow/pull/34152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org