You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/07/06 02:24:05 UTC
[GitHub] [kylin] tianhui5 opened a new pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
tianhui5 opened a new pull request #1680:
URL: https://github.com/apache/kylin/pull/1680
## Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-5021
## Types of changes
- [x ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
- [x ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter edited a comment on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-874641285
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@c51b481`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1680 +/- ##
======================================================
Coverage ? 24.62%
Complexity ? 4832
======================================================
Files ? 1162
Lines ? 66514
Branches ? 9621
======================================================
Hits ? 16382
Misses ? 48398
Partials ? 1734
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c51b481...8407c79](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] xiacongling commented on a change in pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
xiacongling commented on a change in pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#discussion_r664348908
##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##########
@@ -330,7 +330,7 @@ class FilePruner(cubeInstance: CubeInstance,
}
case _ =>
//other unary filter like EqualTo, GreaterThan, GreaterThanOrEqual, etc.
- if (filter.references.subsetOf(AttributeSet(col))) {
+ if (col != null && filter.references.subsetOf(AttributeSet(col))) {
Review comment:
I think we can move the null-check to the beginning of the method, so that the mothed would not go into the recursion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp merged pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
zzcclp merged pull request #1680:
URL: https://github.com/apache/kylin/pull/1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
zzcclp commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-881338891
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
zzcclp commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-881339221
Merged, thanks @tianhui5 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 commented on a change in pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
tianhui5 commented on a change in pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#discussion_r670927620
##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/catalyst/expressions/KylinExpresssions.scala
##########
@@ -492,7 +492,7 @@ case class ScatterSkewData(left: Expression, right: Expression) extends BinaryEx
val rand = ctx.addMutableState("java.util.Random", "rand")
val skewData = ctx.addMutableState("it.unimi.dsi.fastutil.objects.Object2LongOpenHashMap",
"skewData")
- val skewDataStorage = right.simpleString
+ val skewDataStorage = ExpressionUtils.simpleString(right)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-874641285
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@dc499be`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1680 +/- ##
======================================================
Coverage ? 24.66%
Complexity ? 4832
======================================================
Files ? 1159
Lines ? 66426
Branches ? 9609
======================================================
Hits ? 16382
Misses ? 48311
Partials ? 1733
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc499be...69929aa](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
zzcclp commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-881132832
Only one comment left, others LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#discussion_r670922906
##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/catalyst/expressions/KylinExpresssions.scala
##########
@@ -492,7 +492,7 @@ case class ScatterSkewData(left: Expression, right: Expression) extends BinaryEx
val rand = ctx.addMutableState("java.util.Random", "rand")
val skewData = ctx.addMutableState("it.unimi.dsi.fastutil.objects.Object2LongOpenHashMap",
"skewData")
- val skewDataStorage = right.simpleString
+ val skewDataStorage = ExpressionUtils.simpleString(right)
Review comment:
Please rebase to branch kylin-on-parquet-v2, I have fixed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-874641285
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@dc499be`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1680 +/- ##
======================================================
Coverage ? 24.66%
Complexity ? 4832
======================================================
Files ? 1159
Lines ? 66426
Branches ? 9609
======================================================
Hits ? 16382
Misses ? 48311
Partials ? 1733
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc499be...69929aa](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] xiacongling commented on a change in pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
xiacongling commented on a change in pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#discussion_r664348908
##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##########
@@ -330,7 +330,7 @@ class FilePruner(cubeInstance: CubeInstance,
}
case _ =>
//other unary filter like EqualTo, GreaterThan, GreaterThanOrEqual, etc.
- if (filter.references.subsetOf(AttributeSet(col))) {
+ if (col != null && filter.references.subsetOf(AttributeSet(col))) {
Review comment:
I think we can move the null-check to the beginning of the method, so that the mothed would not go into the recursion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] xiacongling commented on pull request #1680: KYLIN-5021 FilePruner throws NPE when there is no timePartitionColunm in cube
Posted by GitBox <gi...@apache.org>.
xiacongling commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-881101267
@zzcclp could you review this PR? It's a bugfix for kylin4 using spark v3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org