[jira] [Work logged] (HIVE-25150) Tab characters are not removed before decimal conversion similar to space character which is fixed as part of HIVE-24378

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25150?focusedWorklogId=600410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600410 ]

ASF GitHub Bot logged work on HIVE-25150:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/21 15:06
            Start Date: 21/May/21 15:06
    Worklog Time Spent: 10m 
      Work Description: tarak271 opened a new pull request #2308:
URL: https://github.com/apache/hive/pull/2308


   
   
   ### What changes were proposed in this pull request?
   Skipping tab characters before decimal conversion in decimal type column values
   
   ### Why are the changes needed?
   Comply with other Relational Databases like MySQL
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, if decimal value contains tab character, then it will be trimmed and actual value is returned instead of returning NULL
   
   
   ### How was this patch tested?
   Qtest added in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 600410)
    Remaining Estimate: 0h
            Time Spent: 10m

> Tab characters are not removed before decimal conversion similar to space character which is fixed as part of HIVE-24378
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-25150
>                 URL: https://issues.apache.org/jira/browse/HIVE-25150
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: 4.0.0
>            Reporter: Taraka Rama Rao Lethavadla
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Test case: 
>  column values with space and tab character 
> {noformat}
> bash-4.2$ cat data/files/test_dec_space.csv
> 1,0
> 2, 1
> 3,	2{noformat}
> {noformat}
> create external table test_dec_space (id int, value decimal) ROW FORMAT DELIMITED
>  FIELDS TERMINATED BY ',' location '/tmp/test_dec_space';
> {noformat}
> output of select * from test_dec_space would be
> {noformat}
> 1	0
> 2	1
> 3	NULL{noformat}
> The behaviour in MySQL when there is tab & space characters in decimal values
> {noformat}
> bash-4.2$ cat /tmp/insert.csv 
> "1","aa",11.88
> "2","bb", 99.88
> "4","dd",	209.88{noformat}
>  
> {noformat}
> MariaDB [test]> load data local infile '/tmp/insert.csv' into table t2 fields terminated by ',' ENCLOSED BY '"' LINES TERMINATED BY '\n';
>  Query OK, 3 rows affected, 3 warnings (0.00 sec) 
>  Records: 3 Deleted: 0 Skipped: 0 Warnings: 3
> MariaDB [test]> select * from t2;
> +------+------+-------+
> | id   | name | score |
> +------+------+-------+
> | 1    | aa   |    12 |
> | 2    | bb   |   100 |
> | 4    | dd   |   210 |
> +------+------+-------+
>  3 rows in set (0.00 sec)
> {noformat}
> So hive should not show up NULL 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)