You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jitendra Pandey <ji...@hortonworks.com> on 2014/03/10 18:02:08 UTC
Review Request 18972: Vectorized cast of decimal to string and timestamp
produces incorrect result.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18972/
-----------------------------------------------------------
Review request for hive and Eric Hanson.
Repository: hive-git
Description
-------
Vectorized cast of decimal to string and timestamp produces incorrect result.
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 9d25620
common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java 34bd9d0
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java debc270
common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java 9ac68fe
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToString.java 2e8c3a4
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java df7e1ee
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 832463d
ql/src/test/queries/clientpositive/vector_decimal_expressions.q 38934d2
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 629f5d5
Diff: https://reviews.apache.org/r/18972/diff/
Testing
-------
Thanks,
Jitendra Pandey
Re: Review Request 18972: Vectorized cast of decimal to string and timestamp
produces incorrect result.
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18972/#review36703
-----------------------------------------------------------
Overall it looks good. Please see my specific comments.
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java
<https://reviews.apache.org/r/18972/#comment67785>
Please add one or more tests with a large integer with trailing zeros, e.g.
1234123000
to make sure that comes our right (no zeros get lopped off).
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java
<https://reviews.apache.org/r/18972/#comment67784>
Please comment why you're using this logic.
- Eric Hanson
On March 10, 2014, 5:02 p.m., Jitendra Pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18972/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 5:02 p.m.)
>
>
> Review request for hive and Eric Hanson.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Vectorized cast of decimal to string and timestamp produces incorrect result.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 9d25620
> common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java 34bd9d0
> common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java debc270
> common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java 9ac68fe
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToString.java 2e8c3a4
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java df7e1ee
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 832463d
> ql/src/test/queries/clientpositive/vector_decimal_expressions.q 38934d2
> ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 629f5d5
>
> Diff: https://reviews.apache.org/r/18972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jitendra Pandey
>
>
Re: Review Request 18972: Vectorized cast of decimal to string and timestamp
produces incorrect result.
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18972/#review36803
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Hanson
On March 10, 2014, 9:51 p.m., Jitendra Pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18972/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 9:51 p.m.)
>
>
> Review request for hive and Eric Hanson.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Vectorized cast of decimal to string and timestamp produces incorrect result.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 9d25620
> common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java 34bd9d0
> common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java debc270
> common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java 9ac68fe
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToString.java 2e8c3a4
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java df7e1ee
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 832463d
> ql/src/test/queries/clientpositive/vector_decimal_expressions.q 38934d2
> ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 629f5d5
>
> Diff: https://reviews.apache.org/r/18972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jitendra Pandey
>
>
Re: Review Request 18972: Vectorized cast of decimal to string and timestamp
produces incorrect result.
Posted by Jitendra Pandey <ji...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18972/
-----------------------------------------------------------
(Updated March 10, 2014, 9:51 p.m.)
Review request for hive and Eric Hanson.
Changes
-------
Updated patch addresses the comments.
Repository: hive-git
Description
-------
Vectorized cast of decimal to string and timestamp produces incorrect result.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 9d25620
common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java 34bd9d0
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java debc270
common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java 9ac68fe
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToString.java 2e8c3a4
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java df7e1ee
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 832463d
ql/src/test/queries/clientpositive/vector_decimal_expressions.q 38934d2
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 629f5d5
Diff: https://reviews.apache.org/r/18972/diff/
Testing
-------
Thanks,
Jitendra Pandey