You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mo...@apache.org on 2009/06/03 09:29:20 UTC

svn commit: r781286 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/order/ordershippinginfo.ftl

Author: mor
Date: Wed Jun  3 07:29:20 2009
New Revision: 781286

URL: http://svn.apache.org/viewvc?rev=781286&view=rev
Log:
Better label. This is used on Order Detail Page > Action screenlet and this would now describe the action in better way for the user.

Modified:
    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
    ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl

Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=781286&r1=781285&r2=781286&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
+++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Wed Jun  3 07:29:20 2009
@@ -4830,8 +4830,8 @@
         <value xml:lang="zh">订单头信息</value>
         <value xml:lang="zh_CN">订单头信息</value>
     </property>
-    <property key="OrderOrderHistory">
-        <value xml:lang="en">Order History</value>
+    <property key="OrderViewOrderHistory">
+        <value xml:lang="en">View Order History</value>
     </property>
     <property key="OrderOrderId">
         <value xml:lang="de">Auftrag ID</value>

Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=781286&r1=781285&r2=781286&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl (original)
+++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl Wed Jun  3 07:29:20 2009
@@ -101,7 +101,7 @@
             <li><a href="<@o...@ofbizUrl>" class="buttontext">${uiLabelMap.OrderCreateReplacementOrder}</a></li>
           </#if>
         </#if>
-        <li><a href="<@o...@ofbizUrl>" class="buttontext">${uiLabelMap.OrderOrderHistory}</a></li>
+        <li><a href="<@o...@ofbizUrl>" class="buttontext">${uiLabelMap.OrderViewOrderHistory}</a></li>
       </ul>
     </div>
   </div>

Re: svn commit: r781286 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/order/ordershippinginfo.ftl

Posted by Vikas Mayur <vi...@hotwaxmedia.com>.
Hi Hans,

comments inline.

Vikas

On Jun 3, 2009, at 1:13 PM, Hans Bakker wrote:

>
> 2 problems with this change:
>
> 1: "Order History" changed to "View Order History": does this mean we
> will put everywhere an action before the object?  like "view invoice",
> "view product" etc?

I am not sure of other references. The only reason for doing this is  
because of the name of the screenlet (Action) which hold all these  
labels/link.


>
>
> 2: if you rename labels please check if they are used elsewhere....in
> this case the old label is also used in OrderviewScreens.xml where now
> this label is missing.....

Yes - Indeed. They should be checked for any existing reference(s).  
Certainly I miss them on this occasion. Thanks for letting me know and  
I have fixed this in rev. 781292 while keeping the "View Order  
History" label intact.

>
>
> Regards,
> Hans
>
>
>
> On Wed, 2009-06-03 at 07:29 +0000, mor@apache.org wrote:
>> Author: mor
>> Date: Wed Jun  3 07:29:20 2009
>> New Revision: 781286
>>
>> URL: http://svn.apache.org/viewvc?rev=781286&view=rev
>> Log:
>> Better label. This is used on Order Detail Page > Action screenlet  
>> and this would now describe the action in better way for the user.
>>
>> Modified:
>>    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>>    ofbiz/trunk/applications/order/webapp/ordermgr/order/ 
>> ordershippinginfo.ftl
>>
>> Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=781286&r1=781285&r2=781286&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- ofbiz/trunk/applications/order/config/OrderUiLabels.xml  
>> (original)
>> +++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Wed  
>> Jun  3 07:29:20 2009
>> @@ -4830,8 +4830,8 @@
>>         <value xml:lang="zh">订单头信息</value>
>>         <value xml:lang="zh_CN">订单头信息</value>
>>     </property>
>> -    <property key="OrderOrderHistory">
>> -        <value xml:lang="en">Order History</value>
>> +    <property key="OrderViewOrderHistory">
>> +        <value xml:lang="en">View Order History</value>
>>     </property>
>>     <property key="OrderOrderId">
>>         <value xml:lang="de">Auftrag ID</value>
>>
>> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ 
>> ordershippinginfo.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=781286&r1=781285&r2=781286&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/order/ 
>> ordershippinginfo.ftl (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ 
>> ordershippinginfo.ftl Wed Jun  3 07:29:20 2009
>> @@ -101,7 +101,7 @@
>>             <li><a href="<@ofbizUrl>loadCartForReplacementOrder?$ 
>> {paramString}</...@ofbizUrl>" class="buttontext">$ 
>> {uiLabelMap.OrderCreateReplacementOrder}</a></li>
>>           </#if>
>>         </#if>
>> -        <li><a href="<@ofbizUrl>OrderHistory?orderId=${orderId}</ 
>> @ofbizUrl>" class="buttontext">${uiLabelMap.OrderOrderHistory}</a></ 
>> li>
>> +        <li><a href="<@ofbizUrl>OrderHistory?orderId=${orderId}</ 
>> @ofbizUrl>" class="buttontext">${uiLabelMap.OrderViewOrderHistory}</ 
>> a></li>
>>       </ul>
>>     </div>
>>   </div>
>>
>>
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
>

Re: svn commit: r781286 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/order/ordershippinginfo.ftl

Posted by Hans Bakker <ma...@antwebsystems.com>.
2 problems with this change:

1: "Order History" changed to "View Order History": does this mean we
will put everywhere an action before the object?  like "view invoice",
"view product" etc?

2: if you rename labels please check if they are used elsewhere....in
this case the old label is also used in OrderviewScreens.xml where now
this label is missing.....

Regards,
Hans



On Wed, 2009-06-03 at 07:29 +0000, mor@apache.org wrote:
> Author: mor
> Date: Wed Jun  3 07:29:20 2009
> New Revision: 781286
> 
> URL: http://svn.apache.org/viewvc?rev=781286&view=rev
> Log:
> Better label. This is used on Order Detail Page > Action screenlet and this would now describe the action in better way for the user.
> 
> Modified:
>     ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>     ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
> 
> Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=781286&r1=781285&r2=781286&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
> +++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Wed Jun  3 07:29:20 2009
> @@ -4830,8 +4830,8 @@
>          <value xml:lang="zh">订单头信息</value>
>          <value xml:lang="zh_CN">订单头信息</value>
>      </property>
> -    <property key="OrderOrderHistory">
> -        <value xml:lang="en">Order History</value>
> +    <property key="OrderViewOrderHistory">
> +        <value xml:lang="en">View Order History</value>
>      </property>
>      <property key="OrderOrderId">
>          <value xml:lang="de">Auftrag ID</value>
> 
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?rev=781286&r1=781285&r2=781286&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl Wed Jun  3 07:29:20 2009
> @@ -101,7 +101,7 @@
>              <li><a href="<@o...@ofbizUrl>" class="buttontext">${uiLabelMap.OrderCreateReplacementOrder}</a></li>
>            </#if>
>          </#if>
> -        <li><a href="<@o...@ofbizUrl>" class="buttontext">${uiLabelMap.OrderOrderHistory}</a></li>
> +        <li><a href="<@o...@ofbizUrl>" class="buttontext">${uiLabelMap.OrderViewOrderHistory}</a></li>
>        </ul>
>      </div>
>    </div>
> 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates