You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/07 06:39:29 UTC
[GitHub] [ozone] GlenGeng opened a new pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
GlenGeng opened a new pull request #1902:
URL: https://github.com/apache/ozone/pull/1902
## What changes were proposed in this pull request?
After spotbugs is enabled with HDDS-2195, there are additional issues reported by findbugs. These issues have to fixed.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4797
## How was this patch tested?
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774822273
After last two merge of master, we have four failures, one is findBugs, due to the second merge,
The first merge cause the failure unit test(TestContainerEndpoint, TestReconContainerManager) and misc docker.
The second merge cause the failure of find bugs.
The fix is aims to the find bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774748817
Overall LGTM if we can confirm the `acceptance tests` are not regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774748708
`org.apache.hadoop.ozone.recon.api.TestContainerEndpoint` failed due to 500 error which seems not relevant.
`org.apache.hadoop.ozone.recon.scm.TestReconContainerManager` probably is still related to recon.
But the acceptance tests seem wired:
```
------------------------------------------------------------------------------
List pipelines on unknown host | FAIL |
'Pipeline[ Id: a7efa2fd-f50d-4176-9749-5dde54cbefd6, Nodes: 7bd494ef-c457-4af3-b39b-6336ccda3d1a{ip: 172.26.0.3, host: ozonescripts_datanode_1.ozonescripts_default, ports: [REPLICATION=9886, RATIS=9858, STANDALONE=9859], networkLocation: /default-rack, certSerialId: null, persistedOpState: IN_SERVICE, persistedOpStateExpiryEpochSec: 0}, Type:STAND_ALONE, Factor:ONE, State:CLOSED, leaderId:, CreationTimestamp2021-02-07T07:45:04.624Z]
Pipeline[ Id: ac7c1c4a-adbe-4be8-bd5f-52de37d4119e, Nodes: 7bd494ef-c457-4af3-b39b-6336ccda3d1a{ip: 172.26.0.3, host: ozonescripts_datanode_1.ozonescripts_default, ports: [REPLICATION=9886, RATIS=9858, STANDALONE=9859], networkLocation: /default-rack, certSerialId: null, persistedOpState: IN_SERVICE, persistedOpStateExpiryEpochSec: 0}, Type:RATIS, Factor:ONE, State:OPEN, leaderId:7bd494ef-c457-4af3-b39b-6336ccda3d1a, CreationTimestamp2021-02-07T07:44:41.689Z]' does not contain 'Invalid host name'
------------------------------------------------------------------------------
Pipeline :: Test ozone admin pipeline command | FAIL |
8 critical tests, 7 passed, 1 failed
8 tests total, 7 passed, 1 failed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774823249
> `org.apache.hadoop.ozone.recon.api.TestContainerEndpoint` failed due to 500 error which seems not relevant.
> `org.apache.hadoop.ozone.recon.scm.TestReconContainerManager` probably is still related to recon.
>
> But the acceptance tests seem wired:
>
> ```
> ------------------------------------------------------------------------------
> List pipelines on unknown host | FAIL |
> 'Pipeline[ Id: a7efa2fd-f50d-4176-9749-5dde54cbefd6, Nodes: 7bd494ef-c457-4af3-b39b-6336ccda3d1a{ip: 172.26.0.3, host: ozonescripts_datanode_1.ozonescripts_default, ports: [REPLICATION=9886, RATIS=9858, STANDALONE=9859], networkLocation: /default-rack, certSerialId: null, persistedOpState: IN_SERVICE, persistedOpStateExpiryEpochSec: 0}, Type:STAND_ALONE, Factor:ONE, State:CLOSED, leaderId:, CreationTimestamp2021-02-07T07:45:04.624Z]
> Pipeline[ Id: ac7c1c4a-adbe-4be8-bd5f-52de37d4119e, Nodes: 7bd494ef-c457-4af3-b39b-6336ccda3d1a{ip: 172.26.0.3, host: ozonescripts_datanode_1.ozonescripts_default, ports: [REPLICATION=9886, RATIS=9858, STANDALONE=9859], networkLocation: /default-rack, certSerialId: null, persistedOpState: IN_SERVICE, persistedOpStateExpiryEpochSec: 0}, Type:RATIS, Factor:ONE, State:OPEN, leaderId:7bd494ef-c457-4af3-b39b-6336ccda3d1a, CreationTimestamp2021-02-07T07:44:41.689Z]' does not contain 'Invalid host name'
> ------------------------------------------------------------------------------
> Pipeline :: Test ozone admin pipeline command | FAIL |
> 8 critical tests, 7 passed, 1 failed
> 8 tests total, 7 passed, 1 failed
> ```
@amaliujia Thanks for the review! The issues mentioned above is due to the merge of recon due to the first master merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on a change in pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#discussion_r571802766
##########
File path: hadoop-hdds/server-scm/dev-support/findbugsExcludeFile.xml
##########
@@ -47,4 +47,8 @@
<Class name="org.apache.hadoop.hdds.scm.server.TestSCMSecurityProtocolServer" />
<Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
</Match>
+ <Match>
+ <Class name="org.apache.hadoop.hdds.scm.metadata.TestSCMTransactionInfoCodec"/>
Review comment:
This is the same handling way of `org.apache.hadoop.hdds.scm.metadata.TestOMTransactionInfoCodec`. Just keep consistent here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-775369707
Thanks @GlenGeng for your fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1902:
URL: https://github.com/apache/ozone/pull/1902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng edited a comment on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774822273
After last two merge of master, we have four failures:
The first merge cause the failure unit test (TestContainerEndpoint, TestReconContainerManager) and misc docker test.
The second merge cause the failure of find bugs.
The fix is aims to the find bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng edited a comment on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774822273
After last two merge of master, we have four failures:
The first merge cause the failure unit test (TestContainerEndpoint, TestReconContainerManager) and misc docker test.
The second merge cause the failure of find bugs.
The fix is aims to the find bugs.
@nandakumar131 @bshashikant @amaliujia Please take a look!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1902: HDDS-4797: Fix findbugs issues after HDDS-2195
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1902:
URL: https://github.com/apache/ozone/pull/1902#issuecomment-774748708
`org.apache.hadoop.ozone.recon.api.TestContainerEndpoint` failed due to 500 which seems not relevant.
`org.apache.hadoop.ozone.recon.scm.TestReconContainerManager` probably is still related to recon.
But the acceptance tests seem wired:
```
------------------------------------------------------------------------------
List pipelines on unknown host | FAIL |
'Pipeline[ Id: a7efa2fd-f50d-4176-9749-5dde54cbefd6, Nodes: 7bd494ef-c457-4af3-b39b-6336ccda3d1a{ip: 172.26.0.3, host: ozonescripts_datanode_1.ozonescripts_default, ports: [REPLICATION=9886, RATIS=9858, STANDALONE=9859], networkLocation: /default-rack, certSerialId: null, persistedOpState: IN_SERVICE, persistedOpStateExpiryEpochSec: 0}, Type:STAND_ALONE, Factor:ONE, State:CLOSED, leaderId:, CreationTimestamp2021-02-07T07:45:04.624Z]
Pipeline[ Id: ac7c1c4a-adbe-4be8-bd5f-52de37d4119e, Nodes: 7bd494ef-c457-4af3-b39b-6336ccda3d1a{ip: 172.26.0.3, host: ozonescripts_datanode_1.ozonescripts_default, ports: [REPLICATION=9886, RATIS=9858, STANDALONE=9859], networkLocation: /default-rack, certSerialId: null, persistedOpState: IN_SERVICE, persistedOpStateExpiryEpochSec: 0}, Type:RATIS, Factor:ONE, State:OPEN, leaderId:7bd494ef-c457-4af3-b39b-6336ccda3d1a, CreationTimestamp2021-02-07T07:44:41.689Z]' does not contain 'Invalid host name'
------------------------------------------------------------------------------
Pipeline :: Test ozone admin pipeline command | FAIL |
8 critical tests, 7 passed, 1 failed
8 tests total, 7 passed, 1 failed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org