You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by fl...@apache.org on 2018/08/30 14:31:30 UTC

[46/50] tinkerpop git commit: Enabled some asserts that were commented out on path serialization tests

Enabled some asserts that were commented out on path serialization tests

Not sure why this was commented out but it wasn't working at some point apparently - oh well, working now CTR


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/94d9de04
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/94d9de04
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/94d9de04

Branch: refs/heads/TINKERPOP-1774
Commit: 94d9de04c3d9ad22efd0cbd4b9d29a3dfb6e0b92
Parents: 5ca6998
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Tue Aug 28 16:20:57 2018 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Tue Aug 28 16:20:57 2018 -0400

----------------------------------------------------------------------
 .../gremlin/structure/SerializationTest.java      | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/94d9de04/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/SerializationTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/SerializationTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/SerializationTest.java
index 4935175..0f910ab 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/SerializationTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/SerializationTest.java
@@ -722,27 +722,24 @@ public class SerializationTest {
             assertEquals(vOut.label(), detachedVOut.label());
             assertEquals(vOut.id(), detachedVOut.id());
 
-            // TODO: dunno GraphSON seems to return properties - will make this more consistent here
             // this is a SimpleTraverser so no properties are present in detachment
-            //assertFalse(detachedVOut.properties().hasNext());
+            assertFalse(detachedVOut.properties().hasNext());
 
             final Edge e = p.get("b");
             final Edge detachedE = detached.get("b");
             assertEquals(e.label(), detachedE.label());
             assertEquals(e.id(), detachedE.id());
 
-            // TODO: dunno GraphSON seems to return properties - will make this more consistent here
             // this is a SimpleTraverser so no properties are present in detachment
-            //assertFalse(detachedE.properties().hasNext());
+            assertFalse(detachedE.properties().hasNext());
 
             final Vertex vIn = p.get("c");
             final Vertex detachedVIn = detached.get("c");
             assertEquals(vIn.label(), detachedVIn.label());
             assertEquals(vIn.id(), detachedVIn.id());
 
-            // TODO: dunno GraphSON seems to return properties - will make this more consistent here
             // this is a SimpleTraverser so no properties are present in detachment
-            //assertFalse(detachedVIn.properties().hasNext());
+            assertFalse(detachedVIn.properties().hasNext());
         }
 
         @Test
@@ -927,27 +924,24 @@ public class SerializationTest {
             assertEquals(vOut.label(), detachedVOut.label());
             assertEquals(vOut.id(), detachedVOut.id());
 
-            // TODO: dunno GraphSON seems to return properties - will make this more consistent here
             // this is a SimpleTraverser so no properties are present in detachment
-            //assertFalse(detachedVOut.properties().hasNext());
+            assertFalse(detachedVOut.properties().hasNext());
 
             final Edge e = p.get("b");
             final Edge detachedE = detached.get("b");
             assertEquals(e.label(), detachedE.label());
             assertEquals(e.id(), detachedE.id());
 
-            // TODO: dunno GraphSON seems to return properties - will make this more consistent here
             // this is a SimpleTraverser so no properties are present in detachment
-            //assertFalse(detachedE.properties().hasNext());
+            assertFalse(detachedE.properties().hasNext());
 
             final Vertex vIn = p.get("c");
             final Vertex detachedVIn = detached.get("c");
             assertEquals(vIn.label(), detachedVIn.label());
             assertEquals(vIn.id(), detachedVIn.id());
 
-            // TODO: dunno GraphSON seems to return properties - will make this more consistent here
             // this is a SimpleTraverser so no properties are present in detachment
-            //assertFalse(detachedVIn.properties().hasNext());
+            assertFalse(detachedVIn.properties().hasNext());
         }
 
         @Test