You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/11/03 22:27:57 UTC
[GitHub] [gobblin] arjun4084346 opened a new pull request, #3597: add a config to set MR jobs jar path in CompactionSource
arjun4084346 opened a new pull request, #3597:
URL: https://github.com/apache/gobblin/pull/3597
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] umustafi commented on a diff in pull request #3597: add a config to set MR jobs jar path in CompactionSource
Posted by GitBox <gi...@apache.org>.
umustafi commented on code in PR #3597:
URL: https://github.com/apache/gobblin/pull/3597#discussion_r1024416007
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/source/CompactionSource.java:
##########
@@ -128,7 +129,12 @@ public WorkUnitStream getWorkunitStream(SourceState state) {
// Spawn a single thread to create work units
new Thread(new SingleWorkUnitGeneratorService(state, prioritize(datasets, state), workUnitIterator), "SingleWorkUnitGeneratorService").start();
- return new BasicWorkUnitStream.Builder(workUnitIterator).build();
+ WorkUnitStream workUnitStream = new BasicWorkUnitStream.Builder(workUnitIterator).build();
+ if (workUnitStream.getWorkUnits().hasNext()) {
+ // copy jars iff workunits are created
Review Comment:
small typo `if`
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/source/CompactionSource.java:
##########
@@ -128,7 +129,12 @@ public WorkUnitStream getWorkunitStream(SourceState state) {
// Spawn a single thread to create work units
new Thread(new SingleWorkUnitGeneratorService(state, prioritize(datasets, state), workUnitIterator), "SingleWorkUnitGeneratorService").start();
- return new BasicWorkUnitStream.Builder(workUnitIterator).build();
+ WorkUnitStream workUnitStream = new BasicWorkUnitStream.Builder(workUnitIterator).build();
+ if (workUnitStream.getWorkUnits().hasNext()) {
+ // copy jars iff workunits are created
Review Comment:
is this to save time for 0 workunit jobs? add a bit more reasoning for why in comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org