You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/25 10:10:32 UTC
[GitHub] [flink] rmetzger opened a new pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
rmetzger opened a new pull request #13779:
URL: https://github.com/apache/flink/pull/13779
## What is the purpose of the change
The Kubernetes e2e test failed once because it failed to build the docker image (network outage). This caused the test to report that the container didn't come up as expected.
With this change, we will retry if the container building failed, and we will immediately return if we could not build the image, leading to better error reporting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13779:
URL: https://github.com/apache/flink/pull/13779#discussion_r512172920
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -19,6 +19,8 @@
source "$(dirname "$0")"/common_kubernetes.sh
+IMAGE_BUILD_RETRIES=3
Review comment:
The reason is that I copy pasted the retry call from somewhere else, where this weird combo of variable and magic number was used.
How about introducing a second variable the magic number? I like these variables just for the sake of self-documentation.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716125299
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238",
"triggerID" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"triggerType" : "PUSH"
}, {
"hash" : "6e42aa7b765d874d454704721381d7f8bee65f22",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8327",
"triggerID" : "6e42aa7b765d874d454704721381d7f8bee65f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e42aa7b765d874d454704721381d7f8bee65f22 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-717770788
Thanks. I'll fix the typo in the commit message & merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716122789
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c38d8adae74db40cddff4757d250a957d8efd43b (Sun Oct 25 10:12:24 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716125299
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238",
"triggerID" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"triggerType" : "PUSH"
}, {
"hash" : "6e42aa7b765d874d454704721381d7f8bee65f22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8327",
"triggerID" : "6e42aa7b765d874d454704721381d7f8bee65f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c38d8adae74db40cddff4757d250a957d8efd43b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238)
* 6e42aa7b765d874d454704721381d7f8bee65f22 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716125299
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238",
"triggerID" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"triggerType" : "PUSH"
}, {
"hash" : "6e42aa7b765d874d454704721381d7f8bee65f22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e42aa7b765d874d454704721381d7f8bee65f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c38d8adae74db40cddff4757d250a957d8efd43b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238)
* 6e42aa7b765d874d454704721381d7f8bee65f22 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716742132
I addressed your comment a bit differently, and pushed it to CI already to have a result tomorrow morning. let me know if yo agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716125299
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c38d8adae74db40cddff4757d250a957d8efd43b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13779:
URL: https://github.com/apache/flink/pull/13779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716125299
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238",
"triggerID" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c38d8adae74db40cddff4757d250a957d8efd43b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13779:
URL: https://github.com/apache/flink/pull/13779#issuecomment-716125299
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238",
"triggerID" : "c38d8adae74db40cddff4757d250a957d8efd43b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c38d8adae74db40cddff4757d250a957d8efd43b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13779:
URL: https://github.com/apache/flink/pull/13779#discussion_r511949631
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -19,6 +19,8 @@
source "$(dirname "$0")"/common_kubernetes.sh
+IMAGE_BUILD_RETRIES=3
Review comment:
What's the reason to use a separate variable that is only used in one place? Might it be better to just move the 3 into the `retry_items` call? ...since we do it for the backoff parameter like that as well. 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org