You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/22 11:16:52 UTC
[GitHub] [spark] Kimahriman opened a new pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Kimahriman opened a new pull request #35934:
URL: https://github.com/apache/spark/pull/35934
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
Follow up for https://github.com/apache/spark/pull/35912#pullrequestreview-915755215, update the executor memoryOverheadFactor to mention the 0.4 default for non-jvm jobs as well.
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Doc update
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To clarify new configs
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075059164
https://github.com/apache/spark/blame/master/docs/running-on-kubernetes.md#L362
Looks like we also missed a minor change in k8s doc, could you also change `spark.kubernetes.memoryOverheadFactor` to `spark.{driver, executor}.memoryOverheadFactor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075059164
https://github.com/apache/spark/blame/master/docs/running-on-kubernetes.md#L362
Looks like we also missed a change in k8s doc, could you also change `spark.kubernetes.memoryOverheadFactor` to `spark.{driver, executor}.memoryOverheadFactor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075184873
yeah looks good, other then the place @Yikun pointed out, if you can update that it would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075201135
Updated that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075043776
@tgravescs if the language sounds good I'll open a 3.3 PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075745915
Thanks, wasn't sure if I was going to need to open a separate PR for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075763551
@Kimahriman no need anymore :)
In general, committer will help you backport commits to target branches if no conflict with target branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075738815
Merged to master / 3.3 (to match what this follows up)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35934:
URL: https://github.com/apache/spark/pull/35934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35934: [SPARK-38194][FOLLOWUP] Update executor config description for memoryOverheadFactor
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35934:
URL: https://github.com/apache/spark/pull/35934#issuecomment-1075763551
@Kimahriman no need anymore :) you can see your commits already in 3.3 by owen helps.
In general, committer will help you backport commits to target branches if no conflict with target branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org