You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Erwan de FERRIERES (JIRA)" <ji...@apache.org> on 2009/09/11 14:44:57 UTC

[jira] Created: (OFBIZ-2930) improvement on geolocalisation

improvement on geolocalisation
------------------------------

                 Key: OFBIZ-2930
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
             Project: OFBiz
          Issue Type: Improvement
          Components: party
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk


the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754756#action_12754756 ] 

Jacques Le Roux commented on OFBIZ-2930:
----------------------------------------

Erwan,

I had a second thought and said to myself that this could be interesting if we provide also a mean to use it or not. I think about a boolean properties useAddressGeoLocation which could be put in general.properties, near the Google block.

But to demonstrate the thing we should also provide OOTB some real addresses, else Google will find nothing. So some parties with real addresses but without geoPoints. I think we should continue this discussion on dev ML. I let you drive the process...

Thanks

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785444#action_12785444 ] 

Jacques Le Roux commented on OFBIZ-2930:
----------------------------------------

Bump!

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754840#action_12754840 ] 

Erwan de FERRIERES commented on OFBIZ-2930:
-------------------------------------------

Thanks Jacques, for reviewing your position on this issue !
I will then initiate a discussion on this point

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785850#action_12785850 ] 

Jacques Le Roux commented on OFBIZ-2930:
----------------------------------------

Thanks for the input Erwan,

OK, I will have a look...

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793671#action_12793671 ] 

Bruno Busco commented on OFBIZ-2930:
------------------------------------

I like it.

One thing only:
field="pointSetAddress" and title="${uiLabelMap.PointSetAddress}" should be actually field="pointAddress" and title="${uiLabelMap.PointAddress}" since it is not a Set of Points but one point only.



> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff, OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2930) improvement on geolocalisation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2930:
--------------------------------------

    Attachment: OFBIZ-2930.diff

Updated version, with an example based on the new screen made by Bruno

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff, OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754757#action_12754757 ] 

Jacques Le Roux commented on OFBIZ-2930:
----------------------------------------

Ha, also we should deal with incorrect addresses (a timeout around Google transaction ?) and provide an error message in such case

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2930) improvement on geolocalisation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2930:
--------------------------------------

    Attachment: OFBIZ-2930.diff

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785848#action_12785848 ] 

Erwan de FERRIERES commented on OFBIZ-2930:
-------------------------------------------

Hi Jacques,

I did started a discussion on this issue, as we discussed here, but had no answer so far...


> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754189#action_12754189 ] 

Jacques Le Roux commented on OFBIZ-2930:
----------------------------------------

Erwan,

Yes we already discussed about that during August 2008. But it's not reliable. Moreover, in OFBiz we decided to not rely on a specific API. Yahoo, etc.. As it's designed and currently coded not only Gogole can be used. Anyway, AFAIK, for the moment, none are sufficiently reliable for this feature in OFBiz.

Nevertheless, before closing this issue with a "later", I think it would be good to discuss about it on the dev ML. BTW, this is one of the Apache OFBiz recommend best practice. Did you read the section "When to create a Jira issue" at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices ?

Thanks

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2930) improvement on geolocalisation

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786508#action_12786508 ] 

Jacques Le Roux commented on OFBIZ-2930:
----------------------------------------

Hi Erwan,

I read your message. I think you can go as you want...

Thanks

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-2930) improvement on geolocalisation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-2930.
-------------------------------------

    Resolution: Fixed

Thanks for the tip !
done at rev. 893277

> improvement on geolocalisation
> ------------------------------
>
>                 Key: OFBIZ-2930
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2930
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2930.diff, OFBIZ-2930.diff
>
>
> the geolocalisation is only working for parties who have a GeoPoint. With the google api, we can also give an address instead of coordinates, and then locate the party on the screen. this patch add this functionality, and then we can locate the parties if they have an address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.