You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/01/10 11:55:00 UTC

[jira] [Work logged] (BEAM-13535) [Playground] Cancel pipeline execution

     [ https://issues.apache.org/jira/browse/BEAM-13535?focusedWorklogId=706030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706030 ]

ASF GitHub Bot logged work on BEAM-13535:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/22 11:54
            Start Date: 10/Jan/22 11:54
    Worklog Time Spent: 10m 
      Work Description: ElessarST commented on a change in pull request #16385:
URL: https://github.com/apache/beam/pull/16385#discussion_r781127063



##########
File path: playground/frontend/lib/pages/playground/states/playground_state.dart
##########
@@ -141,6 +143,18 @@ class PlaygroundState with ChangeNotifier {
     }
   }
 
+  Future<void> cancelRun() async {
+    if (_runSubscription != null) {
+      _runSubscription?.cancel();

Review comment:
       question mark is required because it's not a local variable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 706030)
    Time Spent: 0.5h  (was: 20m)

> [Playground] Cancel pipeline execution
> --------------------------------------
>
>                 Key: BEAM-13535
>                 URL: https://issues.apache.org/jira/browse/BEAM-13535
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-playground
>            Reporter: Aydar Zaynutdinov
>            Assignee: Aydar Farrakhov
>            Priority: P3
>              Labels: beam-playground-frontend, beam-playground-sprint-6, beam-playground-sprint-7
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> As a Beam Playground {*}user{*}, I want to stop the execution of the pipeline in the following cases:
>  # The tab with Playground in the browser was close
>  # Page with Playground was refresh
>  # User click the cancel/stop button
> *Acceptance criteria:*
>  * Cancel button implemented based on visual mockups
>  * Cancelation, when the page was refreshed, is implemented
>  * Cancelation, when the page was close, is implemented



--
This message was sent by Atlassian Jira
(v8.20.1#820001)