You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/09/10 20:05:14 UTC
[GitHub] spark pull request #22384: [SPARK-25398][CORE][MESOS] Minor bugs from compar...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22384
[SPARK-25398][CORE][MESOS] Minor bugs from comparing unrelated types
## What changes were proposed in this pull request?
Correct some comparisons between unrelated types to what they seem to… have been trying to do
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-25398
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22384
----
commit 9e70b625992310a44880a9e42f6fead6c2068dc7
Author: Sean Owen <se...@...>
Date: 2018-09-10T19:58:37Z
Correct some comparisons between unrelated types to what they seem to have been trying to do
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22384
Thanks, @srowen . If you ran `inspection` for all modules, what about removing all tags `[CORE][MESOS]`? Otherwise, could you put `[SQL]` on the title because four `sql` module fixes are included, too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398] Minor bugs from comparing unrelated types
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22384
Merged to master/2.4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22384
**[Test build #4334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4334/testReport)** for PR 22384 at commit [`9e70b62`](https://github.com/apache/spark/commit/9e70b625992310a44880a9e42f6fead6c2068dc7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22384: [SPARK-25398][CORE][MESOS] Minor bugs from compar...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22384#discussion_r216540786
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala ---
@@ -147,7 +147,7 @@ class PropagateEmptyRelationSuite extends PlanTest {
.where(false)
.select('a)
.where('a > 1)
- .where('a != 200)
+ .where('a =!= 200)
--- End diff --
Oh, thank you for fixing this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22384
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22384: [SPARK-25398][CORE][MESOS] Minor bugs from compar...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22384#discussion_r216455205
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala ---
@@ -114,15 +114,15 @@ class UnsafeArraySuite extends SparkFunSuite {
assert(unsafeDate.isInstanceOf[UnsafeArrayData])
assert(unsafeDate.numElements == dateArray.length)
dateArray.zipWithIndex.map { case (e, i) =>
- assert(unsafeDate.get(i, DateType) == e)
+ assert(unsafeDate.get(i, DateType).asInstanceOf[Int] == e)
--- End diff --
Issue here is that you can't really compare `AnyRef` to a primitive, not via boxing or unboxing; this may just be making some Scala coercion explicit but seemed worthwhile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22384: [SPARK-25398][CORE][MESOS] Minor bugs from compar...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22384#discussion_r216454727
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -584,8 +583,7 @@ private object LiveEntityHelpers {
.filter { acc =>
// We don't need to store internal or SQL accumulables as their values will be shown in
// other places, so drop them to reduce the memory usage.
- !acc.internal && (!acc.metadata.isDefined ||
- acc.metadata.get != Some(AccumulatorContext.SQL_ACCUM_IDENTIFIER))
+ !acc.internal && acc.metadata != Some(AccumulatorContext.SQL_ACCUM_IDENTIFIER)
--- End diff --
CC @vanzin on this one for a double-check
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398] Minor bugs from comparing unrelated types
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22384
Looks fine.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22384
**[Test build #95897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95897/testReport)** for PR 22384 at commit [`9e70b62`](https://github.com/apache/spark/commit/9e70b625992310a44880a9e42f6fead6c2068dc7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22384: [SPARK-25398][CORE][MESOS] Minor bugs from compar...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22384#discussion_r216454783
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -175,7 +175,7 @@ private[spark] object ClosureCleaner extends Logging {
closure.getClass.isSynthetic &&
closure
.getClass
- .getInterfaces.exists(_.getName.equals("scala.Serializable"))
+ .getInterfaces.exists(_.getName == "scala.Serializable")
--- End diff --
See JIRA for explanation of this one
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22384
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95897/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22384
**[Test build #95897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95897/testReport)** for PR 22384 at commit [`9e70b62`](https://github.com/apache/spark/commit/9e70b625992310a44880a9e42f6fead6c2068dc7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2989/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22384: [SPARK-25398][CORE][MESOS] Minor bugs from compar...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22384#discussion_r216454913
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala ---
@@ -147,7 +147,7 @@ class PropagateEmptyRelationSuite extends PlanTest {
.where(false)
.select('a)
.where('a > 1)
- .where('a != 200)
+ .where('a =!= 200)
--- End diff --
(`!=` isn't actually the Column operator for historical reasons having to do with precedence)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22384
**[Test build #4334 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4334/testReport)** for PR 22384 at commit [`9e70b62`](https://github.com/apache/spark/commit/9e70b625992310a44880a9e42f6fead6c2068dc7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22384: [SPARK-25398] Minor bugs from comparing unrelated...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22384
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22384: [SPARK-25398][CORE][MESOS] Minor bugs from comparing unr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22384
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org