You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/06/11 10:16:18 UTC

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #586: MINIFICPP-911 - Added ListSFTP and FetchSFTP processors

arpadboda commented on a change in pull request #586: MINIFICPP-911 - Added ListSFTP and FetchSFTP processors
URL: https://github.com/apache/nifi-minifi-cpp/pull/586#discussion_r292337095
 
 

 ##########
 File path: extensions/sftp/CMakeLists.txt
 ##########
 @@ -70,6 +70,9 @@ find_package(ZLIB REQUIRED)
 include_directories(${ZLIB_INCLUDE_DIRS})
 target_link_libraries(minifi-sftp ${ZLIB_LIBRARIES})
 
+# Include RapidJSON
+include_directories(thirdparty/rapidjson-1.1.0/include)
 
 Review comment:
   This might be tricky. 
   
   I didn't check, but I think rapidjson is only built in case C2 is enabled. Turning off C2 and sftp on might end up with compilation errors. (Headers are included, but definitions aren't built by any unit)
   
   Could you check this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services