Re: Potential Felix contribution: ConfigAdmin plugin that can substitute variable placeholders (e.g. for K8s secrets)

[David Bosschaert <da...@gmail.com>]

Hi all,

For the renaming of the configuration property I created:
https://issues.apache.org/jira/browse/FELIX-6165

If a property cannot be replaced, it is already left as-is, with
placeholders brackets and all. I added an extra test to show this:
https://github.com/apache/felix/blob/trunk/configadmin-plugins/interpolation/src/test/java/org/apache/felix/configadmin/plugin/interpolation/InterpolationConfigurationPluginTest.java#L90

Best regards,

David

On Wed, 31 Jul 2019 at 10:22, Carsten Ziegeler <cz...@apache.org> wrote:

> Hi,
>
>
> Georg Henzler wrote
> >>
> >> I assume you're concerned about performance? Without numbers proving
> >> this decreades performance significantly, I wouldn't do any upfront
> >> optimization, especially not if it creates configuration burden.
> >
> >
> > So yes, performance is one part (but most likely not a real problem),
> > the other aspect that for existing projects, there might be false
> > replacements made (I know finding $[] occurrences in existing config
> > values is not that likely, but if for some reason a project has those in
> > their configs it will cause them a major headache to find out what is
> > going on. One good way to mitigate that risk would be to to just leave a
> > reference $[env:key] in the value string unchanged for the case it
> > cannot be replaced (if I read [1] correctly it would currently result in
> > an empty string).
> >
> Ok, I see. Yes, makes sense. I think we should leave the reference in if
> no value is found and probably provide an exclude (regexp) option. This
> way, if you run into the trouble you mention above, you can configure
> the exclude option. But in general you dont have to
>
> Regards
> Carsten
>
> > -Georg
> >
> > [1]
> >
> https://github.com/apache/felix/blob/4c91624c6f1a47c5d6887446cb02fb906b110d40/configadmin-plugins/interpolation/src/main/java/org/apache/felix/configadmin/plugin/interpolation/InterpolationConfigurationPlugin.java#L145
> >
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
>