You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/04/22 23:57:17 UTC
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/
-----------------------------------------------------------
(Updated April 22, 2019, 11:57 p.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
Summary (updated)
-----------------
Transitioned tasks when an unreachable agent is marked as gone.
Bugs: MESOS-9545
https://issues.apache.org/jira/browse/MESOS-9545
Repository: mesos
Description
-------
This patch updates the master code responsible for marking
agents as gone to properly transition tasks on agents which
were previously marked as unreachable.
Diffs
-----
src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b
src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7
src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084
src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
Diff: https://reviews.apache.org/r/70519/diff/1/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214840
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70518, 70519]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 24, 2019, 12:52 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
>
> (Updated April 24, 2019, 12:52 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-9545
> https://issues.apache.org/jira/browse/MESOS-9545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
>
>
> Diffs
> -----
>
> src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
> src/master/master.hpp e8f77d5b107a43945124a9ea00d07562a5a09450
> src/master/master.cpp 73a88a2720be3900e6c6575d9ac535ceec52dc12
> src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
>
>
> Diff: https://reviews.apache.org/r/70519/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214842
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70518', '70519']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3251/mesos-review-70519
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3251/mesos-review-70519/logs/mesos-tests.log):
```
I0424 04:51:40.370427 74936 master.cpp:3312] Disconnecting agent 06c23f02-e3eb-4dd8-ab79-a3df5d520129-S0 at slave(504)@192.10.1.4:63349 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0424 04:51:40.371417 74936 master.cpp:3331] Deactivating agent 06c23f02-e3eb-4dd8-ab79-a3df5d520129-S0 at slave(504)@192.10.1.4:63349 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0424 04:51:40.371417 73644 hierarchical.cpp:392] Removed framework 06c23f02-e3eb-4dd8-ab79-a3df5d520129-0000
I0424 04:51:40.372419 73644 hierarchical.cpp:829] Agent 06c23f02-e3eb-4dd8-ab79-a3df5d520129-S0 deactivated
I0424 04:51:40.373417 74440 containerizer.cpp:2576] Destroying container f80bc0d4-188f-4414-8e0e-a4665ace0336 in RUNNING state
I0424 04:51:40.373417 74440 containerizer.cpp:3278] Transitioning the state of container f80bc0d4-188f-4414-8e0e-a4665ace0336 from RUNNING to DESTROYING
I0424 04:51:40.374425 74440 launcher.cpp:161] Asked to destroy container f80bc0d4-188f-4414-8e0e-a4665ace0336
W0424 04:51:40.375447 74592 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=8556 to peer '192.10.1.4:49373': IO failed with error code: The specified network name is no longer available.
W0424 04:51:40.376427 74592 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10204 to peer '192.10.1.4:49374': IO failed with error code: The specified network name is no longer available.
I0424 04:51:40.398418 73644 containerizer.cpp:3117] Container f80bc0d4-188f-4414-8e0e-a4665ace0336 has exited
I0424 04:51:40.436426 71952 master.cpp:1135] Master terminating
I0424 04:51:40.438437 71884 hierarchical.cpp:680][ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (879 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (898 ms total)
[----------] Global test environment tear-down
[==========] 1166 tests from 109 test cases ran. (588351 ms total)
[ PASSED ] 1163 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
3 FAILED TESTS
YOU HAVE 233 DISABLED TESTS
Removed agent 06c23f02-e3eb-4dd8-ab79-a3df5d520129-S0
I0424 04:51:42.185465 74592 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 24, 2019, 12:52 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
>
> (Updated April 24, 2019, 12:52 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-9545
> https://issues.apache.org/jira/browse/MESOS-9545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
>
>
> Diffs
> -----
>
> src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
> src/master/master.hpp e8f77d5b107a43945124a9ea00d07562a5a09450
> src/master/master.cpp 73a88a2720be3900e6c6575d9ac535ceec52dc12
> src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
>
>
> Diff: https://reviews.apache.org/r/70519/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/
-----------------------------------------------------------
(Updated April 24, 2019, 12:52 a.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
Bugs: MESOS-9545
https://issues.apache.org/jira/browse/MESOS-9545
Repository: mesos
Description
-------
This patch updates the master code responsible for marking
agents as gone to properly transition tasks on agents which
were previously marked as unreachable.
Diffs (updated)
-----
src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
src/master/master.hpp e8f77d5b107a43945124a9ea00d07562a5a09450
src/master/master.cpp 73a88a2720be3900e6c6575d9ac535ceec52dc12
src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
Diff: https://reviews.apache.org/r/70519/diff/3/
Changes: https://reviews.apache.org/r/70519/diff/2-3/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/
-----------------------------------------------------------
(Updated April 24, 2019, 12:46 a.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
Bugs: MESOS-9545
https://issues.apache.org/jira/browse/MESOS-9545
Repository: mesos
Description
-------
This patch updates the master code responsible for marking
agents as gone to properly transition tasks on agents which
were previously marked as unreachable.
Diffs (updated)
-----
src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b
src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
src/master/master.hpp e8f77d5b107a43945124a9ea00d07562a5a09450
src/master/master.cpp 73a88a2720be3900e6c6575d9ac535ceec52dc12
src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
Diff: https://reviews.apache.org/r/70519/diff/2/
Changes: https://reviews.apache.org/r/70519/diff/1-2/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 23, 2019, 4:57 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 9230 (patched)
> > <https://reviews.apache.org/r/70519/diff/1/?file=2140631#file2140631line9230>
> >
> > Nit: I'd probably write this as
> >
> > CHECK(slaves.recovered.contains(slaveId) || slaves.unreachable.contains(slaveId))
> >
> > That way the code matches exactly what's written in the comment.
Done.
> On April 23, 2019, 4:57 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 9243 (patched)
> > <https://reviews.apache.org/r/70519/diff/1/?file=2140631#file2140631line9243>
> >
> > Nit: We could save one level of indentation (and more importantly one item on the reader's mental stack) by writing this as
> >
> > if (framework == nullptr) {
> > continue;
> > }
Done.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214817
-----------------------------------------------------------
On April 24, 2019, 12:52 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
>
> (Updated April 24, 2019, 12:52 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-9545
> https://issues.apache.org/jira/browse/MESOS-9545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
>
>
> Diffs
> -----
>
> src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
> src/master/master.hpp e8f77d5b107a43945124a9ea00d07562a5a09450
> src/master/master.cpp 73a88a2720be3900e6c6575d9ac535ceec52dc12
> src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
>
>
> Diff: https://reviews.apache.org/r/70519/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214817
-----------------------------------------------------------
Fix it, then Ship it!
The change itself looks good to me, so all that follows below are fairly minor style comments.
One thing that we might think about is if we can somehow abstract out the iteration over all tasks itself, since it seems like it is being used in multiple places. However, I didn't really have a good idea of how this should look like, so I did not make a separate comment about that.
src/master/master.cpp
Lines 9225 (patched)
<https://reviews.apache.org/r/70519/#comment301066>
It looks like the `MESOS-XXXX` still needs to be updated.
src/master/master.cpp
Lines 9230 (patched)
<https://reviews.apache.org/r/70519/#comment301067>
Nit: I'd probably write this as
CHECK(slaves.recovered.contains(slaveId) || slaves.unreachable.contains(slaveId))
That way the code matches exactly what's written in the comment.
src/master/master.cpp
Lines 9243 (patched)
<https://reviews.apache.org/r/70519/#comment301071>
Nit: We could save one level of indentation (and more importantly one item on the reader's mental stack) by writing this as
if (framework == nullptr) {
continue;
}
src/master/master.cpp
Lines 9255 (patched)
<https://reviews.apache.org/r/70519/#comment301072>
The return type here looks very dangerous: A correct implementation of `Owned<>` should destroy its contents when it goes out of scope.
I'm a bit torn here because I know it works with our current implementation of `Owned<>`, but it seems a bit odd to "exploit" the implementation details this way.
Maybe we should use `.find()` or `operator[]` instead?
src/master/master.cpp
Lines 9282 (patched)
<https://reviews.apache.org/r/70519/#comment301074>
The same comment as above also applies here, this seems to be leaning very heavily on the fact that `Owned<T>` is in fact `shared_ptr<T>`.
- Benno Evers
On April 22, 2019, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
>
> (Updated April 22, 2019, 11:57 p.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-9545
> https://issues.apache.org/jira/browse/MESOS-9545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
>
>
> Diffs
> -----
>
> src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b
> src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
> src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7
> src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084
> src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
>
>
> Diff: https://reviews.apache.org/r/70519/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214811
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70518', '70519']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3240/mesos-review-70519
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3240/mesos-review-70519/logs/mesos-tests.log):
```
I0423 08:37:41.367103 58160 master.cpp:3333] Disconnecting agent b1762a03-e55a-4dd1-98bd-7a15e69670cb-S0 at slave(503)@192.10.1.4:49323 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0423 08:37:41.367103 58160 master.cpp:3352] Deactivating agent b1762a03-e55a-4dd1-98bd-7a15e69670cb-S0 at slave(503)@192.10.1.4:49323 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0423 08:37:41.367103 67200 hierarchical.cpp:392] Removed framework b1762a03-e55a-4dd1-98bd-7a15e69670cb-0000
I0423 08:37:41.367103 67200 hierarchical.cpp:829] Agent b1762a03-e55a-4dd1-98bd-7a15e69670cb-S0 deactivated
I0423 08:37:41.369081 67680 containerizer.cpp:2576] Destroying container 9efa696d-d7f1-45a1-8016-7d8afb501b86 in RUNNING state
I0423 08:37:41.369081 67680 containerizer.cpp:3278] Transitioning the state of container 9efa696d-d7f1-45a1-8016-7d8afb501b86 from RUNNING to DESTROYING
I0423 08:37:41.369081 67680 launcher.cpp:161] Asked to destroy container 9efa696d-d7f1-45a1-8016-7d8afb501b86
W0423 08:37:41.371099 75280 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10412 to peer '192.10.1.4:51761': IO failed with error code: The specified network name is no lo[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (882 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (902 ms total)
[----------] Global test environment tear-down
[==========] 1164 tests from 109 test cases ran. (596228 ms total)
[ PASSED ] 1161 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
3 FAILED TESTS
YOU HAVE 233 DISABLED TESTS
nger available.
W0423 08:37:41.371099 75280 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=10244 to peer '192.10.1.4:51760': IO failed with error code: The specified network name is no longer available.
I0423 08:37:41.414130 73912 containerizer.cpp:3117] Container 9efa696d-d7f1-45a1-8016-7d8afb501b86 has exited
I0423 08:37:41.448145 72796 master.cpp:1135] Master terminating
I0423 08:37:41.450112 67200 hierarchical.cpp:680] Removed agent b1762a03-e55a-4dd1-98bd-7a15e69670cb-S0
I0423 08:37:42.777107 75280 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 22, 2019, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
>
> (Updated April 22, 2019, 11:57 p.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-9545
> https://issues.apache.org/jira/browse/MESOS-9545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
>
>
> Diffs
> -----
>
> src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b
> src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
> src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7
> src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084
> src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
>
>
> Diff: https://reviews.apache.org/r/70519/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70519: Transitioned tasks when an unreachable
agent is marked as gone.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214805
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70518, 70519]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 22, 2019, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
>
> (Updated April 22, 2019, 11:57 p.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-9545
> https://issues.apache.org/jira/browse/MESOS-9545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
>
>
> Diffs
> -----
>
> src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b
> src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310
> src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7
> src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084
> src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f
>
>
> Diff: https://reviews.apache.org/r/70519/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>