You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/25 05:30:22 UTC
[GitHub] [spark] gengliangwang opened a new pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
gengliangwang opened a new pull request #35659:
URL: https://github.com/apache/spark/pull/35659
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
SubqueryBroadcastExec retrieves the partition key from the broadcast results based on the type of HashedRelation returned. If the key is packed inside a Long, we extract it through bitwise operations and cast it as Byte/Short/Int if necessary.
The casting here can cause a potential runtime error. This PR is to fix it.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Bug fix
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, avoid potential runtime error in dynamic pruning under ANSI mode
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35659:
URL: https://github.com/apache/spark/pull/35659#issuecomment-1050538352
cc @entong as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814495049
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
Review comment:
The default cast returns the lower bits when an overflow happens.
E.g.
```
> select cast(1025L as byte);
1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #35659:
URL: https://github.com/apache/spark/pull/35659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814507560
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
##########
@@ -610,14 +611,19 @@ class HashedRelationSuite extends SharedSparkSession {
val keys = Seq(BoundReference(0, ByteType, false),
BoundReference(1, IntegerType, false),
BoundReference(2, ShortType, false))
- val packed = HashJoin.rewriteKeyExpr(keys)
- val unsafeProj = UnsafeProjection.create(packed)
- val packedKeys = unsafeProj(row)
-
- Seq((0, ByteType), (1, IntegerType), (2, ShortType)).foreach { case (i, dt) =>
- val key = HashJoin.extractKeyExprAt(keys, i)
- val proj = UnsafeProjection.create(key)
- assert(proj(packedKeys).get(0, dt) == -i - 1)
+ // Rewrite and exacting key expressions should not cause exception when ANSI mode is on.
+ Seq("false", "true").foreach { ansiEnabled =>
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> ansiEnabled) {
+ val packed = HashJoin.rewriteKeyExpr(keys)
+ val unsafeProj = UnsafeProjection.create(packed)
+ val packedKeys = unsafeProj(row)
+
+ Seq((0, ByteType), (1, IntegerType), (2, ShortType)).foreach { case (i, dt) =>
Review comment:
nit: is it possible to add some overflow values test as well? Non-blocking comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35659:
URL: https://github.com/apache/spark/pull/35659#issuecomment-1050670398
@cloud-fan @entong @c21 Thanks for the review.
Merging to master/3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814519247
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
Review comment:
I am keepting the `timeZoneId` here since we may support DateType/TimestampType in the future
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
Review comment:
I am keeping the `timeZoneId` here since we may support DateType/TimestampType in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814503811
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
Review comment:
Sorry just for my understanding (without running the unit test by myself): why we expect overflow happens here? Shouldn't `rewriteKeyExpr()` above already guarantees that we only rewrite keys to long when all keys fit into a long type?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
Review comment:
It seems that `rewriteKeyExpr()` above does not support timezone-related data type yet (Line 716). Shall we add an assertion for keys data type to be `IntegralType` and sum of key sizes no larger that 8 bytes in this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814517426
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
Review comment:
ah I see, so this algorithm expects the equivalent of java code `byte b = (byte) long_value`, which is the same as the non-ansi Cast behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814507631
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
Review comment:
@c21 this PR is to avoid exceptions on overflow.
If you run HashedRelationSuite with ANSI mode on, there will be an overflow error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814518191
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
##########
@@ -610,14 +611,19 @@ class HashedRelationSuite extends SharedSparkSession {
val keys = Seq(BoundReference(0, ByteType, false),
BoundReference(1, IntegerType, false),
BoundReference(2, ShortType, false))
- val packed = HashJoin.rewriteKeyExpr(keys)
- val unsafeProj = UnsafeProjection.create(packed)
- val packedKeys = unsafeProj(row)
-
- Seq((0, ByteType), (1, IntegerType), (2, ShortType)).foreach { case (i, dt) =>
- val key = HashJoin.extractKeyExprAt(keys, i)
- val proj = UnsafeProjection.create(key)
- assert(proj(packedKeys).get(0, dt) == -i - 1)
+ // Rewrite and exacting key expressions should not cause exception when ANSI mode is on.
+ Seq("false", "true").foreach { ansiEnabled =>
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> ansiEnabled) {
+ val packed = HashJoin.rewriteKeyExpr(keys)
+ val unsafeProj = UnsafeProjection.create(packed)
+ val packedKeys = unsafeProj(row)
+
+ Seq((0, ByteType), (1, IntegerType), (2, ShortType)).foreach { case (i, dt) =>
Review comment:
This case can already cause overflow on unpacking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814517866
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
Review comment:
Sure, added assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814513431
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
Review comment:
@gengliangwang - got it, thanks for explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] entong commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
entong commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814495366
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
} else {
val shiftedBits =
keys.slice(index + 1, keys.size).map(_.dataType.defaultSize * 8).sum
val mask = (1L << (keys(index).dataType.defaultSize * 8)) - 1
// build the schema for unpacking the required key
- cast(BitwiseAnd(
Review comment:
Do we need to check cast() used in other places to see if they have the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814492704
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
Review comment:
so we do expect to get null value if overflow happens?
cc @c21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #35659: [SPARK-38325][SQL] ANSI mode: avoid potential runtime error in HashJoin.extractKeyExprAt()
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #35659:
URL: https://github.com/apache/spark/pull/35659#discussion_r814500083
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -739,15 +739,24 @@ object HashJoin extends CastSupport with SQLConfHelper {
// jump over keys that have a higher index value than the required key
if (keys.size == 1) {
assert(index == 0)
- cast(BoundReference(0, LongType, nullable = false), keys(index).dataType)
+ Cast(
+ child = BoundReference(0, LongType, nullable = false),
+ dataType = keys(index).dataType,
+ timeZoneId = Option(conf.sessionLocalTimeZone),
+ ansiEnabled = false)
} else {
val shiftedBits =
keys.slice(index + 1, keys.size).map(_.dataType.defaultSize * 8).sum
val mask = (1L << (keys(index).dataType.defaultSize * 8)) - 1
// build the schema for unpacking the required key
- cast(BitwiseAnd(
Review comment:
Yes, I checked and the other usages looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org